Skip to content

Commit d19d731

Browse files
authored
Merge pull request #95 from dwr-zroy/tests/clean-imports
Use `pytest.ini_options.pythonpath` instead of modifying `sys.path` in test modules
2 parents f74d870 + cb4ef15 commit d19d731

12 files changed

Lines changed: 31 additions & 76 deletions

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,4 @@ build-backend = "setuptools.build_meta"
6868
log_cli = true
6969
log_cli_level = 'INFO'
7070
testpaths = ["tests"]
71+
pythonpath = "./src"

tests/test_array.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
"""Pytest module."""
22

33
import unittest
4-
import os
5-
import sys
6-
import numpy as np
74

8-
sys.path.append(r'src')
9-
sys.path.append(os.path.dirname(__file__))
5+
import numpy as np
106
from file_manager import FileManager
11-
from hecdss import HecDss, ArrayContainer
7+
8+
from hecdss import ArrayContainer, HecDss
129

1310

1411
class TestArray(unittest.TestCase):

tests/test_basics.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
"""Pytest module."""
22

33
import unittest
4-
import os
5-
import sys
4+
from datetime import datetime
65

7-
sys.path.append(r'src')
8-
sys.path.append(os.path.dirname(__file__))
96
from file_manager import FileManager
7+
108
from hecdss import Catalog, HecDss
11-
from datetime import datetime
129

1310

1411
class TestBasics(unittest.TestCase):

tests/test_dss_type.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import unittest
2-
import os
3-
import sys
42

5-
sys.path.append(r'src')
6-
sys.path.append(os.path.dirname(__file__))
73
from hecdss.dss_type import DssType
84

95

tests/test_dsspath.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
11
"""Pytest module."""
22

33
import unittest
4-
import os
5-
import sys
6-
7-
sys.path.append(r'src')
8-
sys.path.append(os.path.dirname(__file__))
94

5+
from hecdss import DssPath
106
from hecdss.cwms_utility import CwmsUtility
117
from hecdss.dss_type import DssType
12-
from hecdss import DssPath
138

149

1510
class TestDssPath(unittest.TestCase):

tests/test_gridded_data.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
"""Pytest module."""
22

33
import unittest
4-
import sys
5-
import os
6-
import numpy as np
74

8-
sys.path.append(r'src')
9-
sys.path.append(os.path.dirname(__file__))
5+
import numpy as np
106
from file_manager import FileManager
11-
from hecdss.gridded_data import GriddedData
7+
128
from hecdss import HecDss
9+
from hecdss.gridded_data import GriddedData
1310

1411

1512
class TestGriddedData(unittest.TestCase):

tests/test_irregular_timeseries.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,16 @@
11
"""Pytest module."""
22

3-
import unittest
4-
import sys
53
import os
6-
import numpy as np
7-
8-
9-
sys.path.append(r'src')
10-
sys.path.append(os.path.dirname(__file__))
4+
import sys
5+
import unittest
6+
from datetime import datetime, timedelta
117

8+
import numpy as np
129
from file_manager import FileManager
13-
from hecdss.irregular_timeseries import IrregularTimeSeries
14-
from datetime import datetime, timedelta
10+
1511
from hecdss import HecDss
12+
from hecdss.irregular_timeseries import IrregularTimeSeries
13+
1614

1715
class TestRegularTimeSeries(unittest.TestCase):
1816

tests/test_location_info.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,11 @@
11
"""Pytest module."""
22

33
import unittest
4-
import sys
5-
import os
6-
import numpy as np
7-
8-
sys.path.append(r'src')
9-
sys.path.append(os.path.dirname(__file__))
104

115
from file_manager import FileManager
12-
import copy
13-
from hecdss.paired_data import PairedData
14-
from hecdss.location_info import LocationInfo
6+
157
from hecdss import HecDss
8+
from hecdss.location_info import LocationInfo
169

1710

1811
# update MODIFIED_TEST_DIR to be the path the folder containing dss files

tests/test_paired_data.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,13 @@
11
"""Pytest module."""
22

3+
import copy
34
import unittest
4-
import sys
5-
import os
6-
import numpy as np
7-
8-
sys.path.append(r'src')
9-
sys.path.append(os.path.dirname(__file__))
105

6+
import numpy as np
117
from file_manager import FileManager
12-
import copy
13-
from hecdss.paired_data import PairedData
8+
149
from hecdss import HecDss
10+
from hecdss.paired_data import PairedData
1511

1612

1713
# update MODIFIED_TEST_DIR to be the path the folder containing dss files

tests/test_regular_timeseries.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
"""Pytest module."""
22

33
import unittest
4-
import sys
5-
import os
4+
from datetime import datetime, timedelta
65

76
import numpy as np
7+
from file_manager import FileManager
88

99
from hecdss import HecDss
10-
11-
sys.path.append(r'src')
12-
sys.path.append(os.path.dirname(__file__))
13-
14-
from file_manager import FileManager
1510
from hecdss.regular_timeseries import RegularTimeSeries
16-
from datetime import datetime, timedelta
11+
1712

1813
class TestRegularTimeSeries(unittest.TestCase):
1914

0 commit comments

Comments
 (0)