SNS - Levitation Current Sensor#71
Open
Aux1r wants to merge 27 commits into
Open
Conversation
davidbeechey
changed the title
davidbeechey
requested changes
Feb 7, 2025
Collaborator
davidbeechey
left a comment
davidbeechey
left a comment
There was a problem hiding this comment.
Looks good, just a few things to tidy up
Contributor
Author
|
Rejigged the structure of the |
davidbeechey
requested changes
Feb 10, 2025
TomLonergan03
requested changes
Feb 11, 2025
TomLonergan03
approved these changes
Feb 13, 2025
davidbeechey
approved these changes
Mar 6, 2025
Collaborator
davidbeechey
left a comment
davidbeechey
left a comment
There was a problem hiding this comment.
Looks good, just waiting for testing now
…er/hype-92-implement-current-sensor-for-levitation
davidbeechey
requested changes
Mar 28, 2025
Collaborator
davidbeechey
left a comment
davidbeechey
left a comment
There was a problem hiding this comment.
I'm thinking we should rename this hall_effect rather than levitation_current? Makes it less application specific and more descriptive of the sensor itself
| impl #impl_generics #name #ty_generics { | ||
| pub fn new(adc: Adc<'d, T>, channel: AnyAdcChannel<T>) -> Self { | ||
| Self { adc, channel } | ||
| /// Create a new instance of our ADC implementation for the STM32L476RG |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Create a new instance of our ADC implementation for the STM32L476RG |
…er/hype-92-implement-current-sensor-for-levitation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data sheet: https://docs.broadcom.com/doc/ACHS-712x-DS