Skip to content

INFRA - Cross-platform Build Script#80

Open
platinumxy wants to merge 4 commits into
mainfrom
hype-96-build-file
Open

INFRA - Cross-platform Build Script#80
platinumxy wants to merge 4 commits into
mainfrom
hype-96-build-file

Conversation

@platinumxy
Copy link
Copy Markdown
Contributor

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Feb 9, 2025

HYPE-96 Build file

@platinumxy
Copy link
Copy Markdown
Contributor Author

We need to test on windows, no one with windows env setup was present, will test later

@davidbeechey davidbeechey added the needs reviews Needs reviews, otherwise finished label Feb 9, 2025
Copy link
Copy Markdown
Collaborator

@davidbeechey davidbeechey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda hate it, but if it works it works + it's a bit tidier than 2 files

@davidbeechey davidbeechey changed the title INFRA - Created crossplatform build script INFRA - Cross-platform Build Script Feb 10, 2025
Copy link
Copy Markdown
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

Got both OSs building from the same ps1 file using https://stackoverflow.com/a/67292076
@platinumxy
Copy link
Copy Markdown
Contributor Author

Why did i call that commit both boards working? I ment to put OSs

Copy link
Copy Markdown
Contributor

@TomLonergan03 TomLonergan03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we changing to use this script in the CI job or keep the matrix there?

Comment thread build.ps1
@@ -0,0 +1,48 @@
echo --% >/dev/null;: ' | out-null
<#'
echo "Building main workspace"
Copy link
Copy Markdown
Contributor

@TomLonergan03 TomLonergan03 Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it slighly bothers me that these print different things on the two OSes lol

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops built both without looking at one another, ill fix that later today

@davidbeechey
Copy link
Copy Markdown
Collaborator

are we changing to use this script in the CI job or keep the matrix there?

Keeping the CI job the same - easier to see what jobs are running/failing and doing them in parallel. This script is basically just for “does everything work” during development without having to cd everywhere all the time lol

@davidbeechey davidbeechey removed the needs reviews Needs reviews, otherwise finished label Feb 14, 2025
Copy link
Copy Markdown
Collaborator

@davidbeechey davidbeechey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm coming back to this and I'd be happier if this was two build scripts tbh, one for Windows one for Linux/Mac. The two OS in one file thing is cool though, just not right here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants