Fanhuahuang363/hyp 58 sensors board implementation#23
Open
BL-CZY wants to merge 2 commits into
Open
Conversation
davidbeechey
requested changes
Mar 30, 2026
| 4 => Ok(Board::TemperatureTester), | ||
| 5 => Ok(Board::KeyenceTester), | ||
| 6 => Ok(Board::StateMachineTester), | ||
| 7 => Ok(Board::Mqtt), |
Contributor
There was a problem hiding this comment.
You'll need to add the sensors board here too or it'll throw the error below when it tries to convert it
Comment on lines
+68
to
+76
| EVENT_BUS.sender().send(Event::PrechargeStarted).await; | ||
|
|
||
| led.set_high(); | ||
|
|
||
| embassy_time::Timer::after_secs(10).await; | ||
|
|
||
| led.set_low(); | ||
|
|
||
| EVENT_BUS.sender().send(Event::PrechargeComplete).await; |
Contributor
There was a problem hiding this comment.
Is this board only controlling an LED? If so, I don't think this is the right place to send the PrechargeStarted and PrechargeComplete events.
Is there more logic to be added to this block?
Collaborator
There was a problem hiding this comment.
Yeah eventually this will become the high power relays and such
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.