[fix] typo, from 'opt' to 'param' in isf.InspireFaceSession().#338
Open
liuwake wants to merge 1 commit into
Open
[fix] typo, from 'opt' to 'param' in isf.InspireFaceSession().#338liuwake wants to merge 1 commit into
liuwake wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
PR Summary:
- Fixes a typo in
python/README.mdwhere the keyword argumentopt=was incorrectly documented forisf.InspireFaceSession() - The correct parameter name is
param=, matching the actual__init__signature ininspireface.py - Caused a
TypeErrorfor anyone who copied the README example verbatim
Review Summary:
The change is correct and well-targeted. Verified against InspireFaceSession.__init__() (line 301 of python/inspireface/modules/inspireface.py), which clearly defines param as the first positional argument — not opt. The fix is minimal, accurate, and resolves a real user-facing error reproduced in the PR description. No other occurrences of opt= were found in sample files. No issues identified.
Suggestions
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InspireFace/python/inspireface/modules/inspireface.py
Lines 290 to 326 in a04f63e