Fix: Version drift - Create single source of truth for version number

ISSUE:
- Script had 4 different hardcoded version strings out of sync
- Header comment: 1.0.59 (correct)
- Banner: 1.0.58 (wrong)
- JSON output: 1.0.58 (wrong)
- Log file: 1.0.58 (wrong)
- This caused incorrect version reporting in logs and JSON

ROOT CAUSE:
- Version number was hardcoded in 4 different locations
- No single source of truth for version number
- Easy to forget to update all locations when bumping version

FIX:
- Created SCRIPT_VERSION='1.0.59' constant at line 50
- Added prominent comment block explaining this is the ONLY place
  to update version number
- Replaced all 3 hardcoded version strings with $SCRIPT_VERSION:
  * Line 415: Log file version
  * Line 608: JSON output version
  * Line 1216: Banner version
- Header comment (line 4) kept for documentation

IMPACT:
- Version now displays consistently: 1.0.59 everywhere
- Future version bumps: only update ONE line (line 50)
- Prevents version drift from ever happening again
- Verified in banner, logs, and JSON output

TESTING:
- Ran script with --format json: version shows 1.0.59 ✓
- Ran script with --format text: banner shows v1.0.59 ✓
- Checked log file: Script Version shows 1.0.59 ✓

Author: noelsaw1

1-INBOX/PROJECT-DRY-2.md 2-WORKING/PROJECT-DRY-2.md1-INBOX/PROJECT-DRY-2.md renamed to 2-WORKING/PROJECT-DRY-2.md

@@ -8,6 +8,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [1.0.59] - 2025-12-31
 
 ### Fixed
+- **Version Drift Bug** - Created single source of truth for version number to prevent version inconsistencies
+  - **Issue:** Script had 4 different hardcoded version strings that were out of sync (header: 1.0.59, banner/logs/JSON: 1.0.58)
+  - **Root Cause:** Version number was hardcoded in 4 different locations instead of using a single variable
+  - **Fix:** Created `SCRIPT_VERSION="1.0.59"` constant at top of script and replaced all hardcoded references
+  - **Impact:** Version now displays consistently across banner, logs, and JSON output
+  - **Locations Updated:**
+    - Line 50: Created `SCRIPT_VERSION` variable (single source of truth)
+    - Line 415: Log file version (now uses `$SCRIPT_VERSION`)
+    - Line 608: JSON output version (now uses `$SCRIPT_VERSION`)
+    - Line 1216: Banner version (now uses `$SCRIPT_VERSION`)
+  - **Future-Proof:** Only need to update ONE line (line 50) when bumping versions
+
 - **Template Loading Path** - Fixed `REPO_ROOT` variable in bash script to correctly load templates from `dist/TEMPLATES/`
   - **Issue:** Script was looking for templates in repository root `/TEMPLATES/` instead of `dist/TEMPLATES/`
   - **Root Cause:** `REPO_ROOT` was set to `$SCRIPT_DIR/../..` (repository root) instead of `$SCRIPT_DIR/..` (dist directory)

CHANGELOG.md

@@ -41,6 +41,14 @@ source "$LIB_DIR/colors.sh"
 # shellcheck source=dist/bin/lib/common-helpers.sh
 source "$LIB_DIR/common-helpers.sh"
 
+# ============================================================
+# VERSION - SINGLE SOURCE OF TRUTH
+# ============================================================
+# This is the ONLY place the version number should be defined.
+# All other references (logs, JSON, banners) use this variable.
+# Update this ONE line when bumping versions - never hardcode elsewhere.
+SCRIPT_VERSION="1.0.59"
+
 # Defaults
 PATHS="."
 STRICT=false
@@ -404,7 +412,7 @@ if [ "$ENABLE_LOGGING" = true ]; then
 
       echo "Generated (UTC):  $(date -u +"%Y-%m-%d %H:%M:%S")"
       echo "Local Time:      $(get_local_timestamp)"
-        echo "Script Version:   1.0.58"
+        echo "Script Version:   $SCRIPT_VERSION"
       echo "Paths Scanned:    $PATHS"
       echo "Strict Mode:      $STRICT"
       echo "Verbose Mode:     $VERBOSE"
@@ -597,7 +605,7 @@ output_json() {
 
     cat <<EOF
 {
-  "version": "1.0.58",
+  "version": "$SCRIPT_VERSION",
   "timestamp": "$timestamp",
   "project": $project_info,
   "paths_scanned": "$(json_escape "$PATHS")",
@@ -1205,7 +1213,7 @@ PROJECT_NAME=$(echo "$PROJECT_INFO_JSON" | grep -o '"name": "[^"]*"' | cut -d'"'
 PROJECT_VERSION=$(echo "$PROJECT_INFO_JSON" | grep -o '"version": "[^"]*"' | cut -d'"' -f4)
 
 			text_echo "${BLUE}━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━${NC}"
-			text_echo "${BLUE}  WP Code Check by Hypercart - Performance Analyzer v1.0.58${NC}"
+			text_echo "${BLUE}  WP Code Check by Hypercart - Performance Analyzer v$SCRIPT_VERSION${NC}"
 		text_echo "${BLUE}━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━${NC}"
 text_echo ""