fix: Remove default SNTP server from Ethernet configuration (#674)

jorgesg82 · FoniksFox · web-flow · commit 1b73710659e3 · 2026-07-10T13:52:39.000+02:00
* fix: Remove default SNTP server from Ethernet configuration

* chore: Add changeset for SNTP default removal

---------

Co-authored-by: FoniksFox &lt;borisbeslimov@gmail.com&gt;
diff --git a/.changesets/ethernet-remove-default-sntp.md b/.changesets/ethernet-remove-default-sntp.md
@@ -0,0 +1,2 @@
+release: patch
+summary: Removes the default SNTP server from Ethernet configuration, defaulting to nullptr instead
diff --git a/Inc/HALAL/Services/Communication/Ethernet/NewEthernet.hpp b/Inc/HALAL/Services/Communication/Ethernet/NewEthernet.hpp
@@ -118,7 +118,7 @@ struct EthernetDomain {
             const char* local_ip,
             const char* subnet_mask = "255.255.0.0",
             const char* gateway = "192.168.1.1",
-            const char* sntp_server = SNTP::DEFAULT_SERVER_IP
+            const char* sntp_server = nullptr
         )
             : pins{pins}, e{local_mac, local_ip, subnet_mask, gateway, sntp_server},
               rmii_gpios{

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+release: patch`
	`2`	`+summary: Removes the default SNTP server from Ethernet configuration, defaulting to nullptr instead`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ struct EthernetDomain {`
`118`	`118`	`const char* local_ip,`
`119`	`119`	`const char* subnet_mask = "255.255.0.0",`
`120`	`120`	`const char* gateway = "192.168.1.1",`
`121`		`- const char* sntp_server = SNTP::DEFAULT_SERVER_IP`
	`121`	`+ const char* sntp_server = nullptr`
`122`	`122`	`)`
`123`	`123`	`: pins{pins}, e{local_mac, local_ip, subnet_mask, gateway, sntp_server},`
`124`	`124`	`rmii_gpios{`