Add a test, fix the error (kind of)

Author: victor-Lopez25

Inc/HALAL/Services/Time/Scheduler.hpp

@@ -50,7 +50,16 @@ struct Scheduler {
         if(microseconds == 0) [[unlikely]] microseconds = 1;
         return register_task(microseconds, func, false);
     }
-    static inline void cancel_timeout(uint8_t id) { unregister_task(id); }
+    static inline void cancel_timeout(uint8_t id) {
+        /* NOTE: This does not fix this case:
+          1. id = set_timeout(x, func)
+          2. timeout ends, func gets called and removed internally
+          3. id_2 = set_timeout(y, func_2) // id will be equal to id_2
+          4. clear_timeout(id) -> will remove the second timeout
+         */
+        if(!tasks_[id].repeating) return;
+        unregister_task(id);
+    }
 
     // static void global_timer_callback();
 

Tests/Time/scheduler_test.cpp

@@ -94,3 +94,22 @@ TEST_F(SchedulerTests, GlobalTickOverflow) {
     // 100 ticks /20 ticks/task = 5 executions.
     EXPECT_EQ(count, 5);
 }
+
+TEST_F(SchedulerTests, TimeoutClearAddTask) {
+    uint8_t timeout_id = Scheduler::set_timeout(10, &fake_workload);
+    Scheduler::start();
+
+    constexpr int NUM_TICKS = 100;
+    for(int i = 0; i < NUM_TICKS; i++) {
+        TIM2_BASE->CNT++;
+        Scheduler::update();
+    }
+
+    // timeout is already done here
+    uint8_t task_id = Scheduler::register_task(20, &fake_workload);
+    
+    // after timeout, cancel task
+    Scheduler::cancel_timeout(timeout_id);
+
+    EXPECT_EQ(Scheduler::active_task_count_, 1);
+}