Skip to content

Commit da1d2f9

Browse files
committed
fix(devcontainer): Implement suggestions
1 parent 6773c6e commit da1d2f9

3 files changed

Lines changed: 2 additions & 5 deletions

File tree

.changesets/devcontainer-none.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
release: none
22
summary: Add devcontainer config and fix some things to hyperloop-firmware-toolchain
33

4-
Use **Ubuntu 22.04** instead of 24.04 in the package image to eliminate the ubuntu 20.04 Noble hack. Also adds **devcontainer** config and installs **stlink-server**.
4+
Use **Ubuntu 22.04** instead of 24.04 in the package image to eliminate the ubuntu 20.04 Focal hack. Also adds **devcontainer** config and installs **stlink-server**.

.devcontainer/devcontainer.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
"dockerfile": "Containerfile"
55
},
66
"workspaceFolder": "/workspaces/${localWorkspaceFolderBasename}",
7-
"runArgs": [
8-
"--userns=keep-id"
9-
],
107
"containerEnv": {
118
"CONTAINER_NAME": "stm32-project"
129
},

ci/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
FROM ubuntu:22.04
22

3-
ENV DEBIAN_FRONTEND=noninteractive
3+
ARG DEBIAN_FRONTEND=noninteractive
44
ARG CUBECLT_VERSION=1.21.0
55
ARG CUBECLT_INSTALLER=cubeclt_${CUBECLT_VERSION}_installer.sh
66

0 commit comments

Comments
 (0)