Skip to content

fix: Remove default SNTP server from Ethernet configuration#674

Merged
jorgesg82 merged 2 commits into
developmentfrom
fix/remove-sntp
Jul 10, 2026
Merged

fix: Remove default SNTP server from Ethernet configuration#674
jorgesg82 merged 2 commits into
developmentfrom
fix/remove-sntp

Conversation

@jorgesg82

@jorgesg82 jorgesg82 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

a tomar por culo

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the implicit default SNTP server configuration from the Ethernet domain configuration API by changing the default sntp_server parameter from SNTP::DEFAULT_SERVER_IP to nullptr, so SNTP time sync is only started when an explicit server is provided.

Changes:

  • Changed EthernetDomain::Ethernet constructor default sntp_server argument to nullptr (disables auto-SNTP by default).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Inc/HALAL/Services/Communication/Ethernet/NewEthernet.hpp
@github-actions

Copy link
Copy Markdown
Contributor

ST-LIB Release Plan

  • Current version: 6.1.3
  • Pending changesets: 5
  • Highest requested bump: minor
  • Next version if merged now: 6.2.0

Pending changes

  • minor Add variable-length TCP orders, diagnostic forwarding, and flush throttling (.changesets/ethernet-diagnostics-forwarding.md)
  • patch Removes the default SNTP server from Ethernet configuration, defaulting to nullptr instead (.changesets/ethernet-remove-default-sntp.md)
  • patch Fix a warning about symbols in HardfaultTrace (doesn't change any behaviour) (.changesets/fix-hwarfault-warning.md)
  • patch Adds a check to ensure return values from Scheduler::get_global_tick() are monotonic (never get decreasing values) (.changesets/scheduler-monotonic.md)
  • minor Makes the watchdog reset check block the system and have a visual indication similar to hardfault (.changesets/visual-watchdog.md)

@jorgesg82
jorgesg82 merged commit 1b73710 into development Jul 10, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants