Skip to content

Commit 07dbc36

Browse files
committed
rename tabs elements
1 parent b0b333d commit 07dbc36

7 files changed

Lines changed: 14 additions & 21 deletions

File tree

ethernet-view/src/layouts/SplitLayout/SplitLayout.tsx

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,10 @@ type Props = {
1313
orientation?: Orientation;
1414
};
1515

16-
//TODO: not rerender elements that dont resize
17-
export const SplitLayout = ({
18-
components,
19-
orientation = Orientation.HORIZONTAL,
20-
}: Props) => {
16+
export const SplitLayout = ({ components, orientation = Orientation.HORIZONTAL }: Props) => {
17+
2118
const minSizes = components.map(() => 0.05);
22-
const [splitElements, onSeparatorMouseDown] = useSplit(
23-
minSizes,
24-
orientation
25-
);
19+
const [splitElements, onSeparatorMouseDown] = useSplit(minSizes, orientation);
2620

2721
return (
2822
<div

ethernet-view/src/layouts/TabLayout/Header/Header.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ import { TabItem } from "layouts/TabLayout/TabItem";
55
type Props = {
66
tabs: TabItem[];
77
visibleTab: TabItem;
8-
handleClick: (tab: TabItem) => void;
8+
onTabClick: (tab: TabItem) => void;
99
};
1010

11-
export const Header = ({ tabs, visibleTab, handleClick }: Props) => {
11+
export const Header = ({ tabs, visibleTab, onTabClick }: Props) => {
1212
return (
1313
<div className={styles.headerWrapper}>
1414
<div className={styles.name}>{visibleTab.name}</div>
1515
{tabs.length > 1 && (
1616
<TabBar
1717
tabs={tabs}
18-
onTabClick={handleClick}
18+
onTabClick={onTabClick}
1919
visibleTabId={visibleTab.id}
2020
/>
2121
)}

ethernet-view/src/layouts/TabLayout/Header/TabBar/TabBar.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ export const TabBar = ({ tabs, onTabClick, visibleTabId }: Props) => {
1818
className={tab.id == visibleTabId ? styles.active : ""}
1919
name={tab.name}
2020
icon={tab.icon}
21-
onClick={() => {
22-
onTabClick(tab);
23-
}}
21+
onClick={() => onTabClick(tab)}
2422
></Tab>
2523
);
2624
})}

ethernet-view/src/layouts/TabLayout/TabLayout.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ type Props = {
1010
export const TabLayout = ({ tabs }: Props) => {
1111
const [visibleTab, setVisibleTab] = useState(tabs[0]);
1212

13-
function handleClick(tab: TabItem) {
13+
function onTabClick(tab: TabItem) {
1414
setVisibleTab(tab);
1515
}
1616

@@ -19,7 +19,7 @@ export const TabLayout = ({ tabs }: Props) => {
1919
<Header
2020
tabs={tabs}
2121
visibleTab={visibleTab}
22-
handleClick={handleClick}
22+
onTabClick={onTabClick}
2323
/>
2424
<div className={styles.body}>
2525
<div className={styles.componentWrapper}>

ethernet-view/src/pages/HomePage/ChartsColumn/ChartsColumn.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import { useMeasurementsStore, usePodDataStore, useSubscribe } from "common";
66
import { createSidebarSections } from "components/ChartMenu/sidebar";
77

88
export const ChartsColumn = () => {
9-
const {podData, updatePodData} = usePodDataStore(state => ({podData: state.podData, updatePodData: state.updatePodData}))
9+
const podData = usePodDataStore(state => state.podData);
10+
const updatePodData = usePodDataStore(state => state.updatePodData)
1011
const updateMeasurements = useMeasurementsStore(state => state.updateMeasurements)
1112

1213
useSubscribe("podData/update", (update) => {

ethernet-view/src/pages/HomePage/HomePage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,11 @@ export const HomePage = () => {
2424
component: <ReceiveColumn />,
2525
collapsedIcon: incomingMessage
2626
},
27-
{ 
27+
{
2828
component: <OrderColumn />,
2929
collapsedIcon: paperAirplane
3030
},
31-
{ 
31+
{
3232
component: <MessagesColumn />,
3333
collapsedIcon: outgoingMessage
3434
},

ethernet-view/src/pages/HomePage/ReceiveColumn/ReceiveColumn.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ReceiveTable } from "components/ReceiveTable/ReceiveTable";
44
import { usePodDataStore } from "common";
55

66
export const ReceiveColumn = () => {
7-
const {podData} = usePodDataStore(state => ({podData: state.podData, updatePodData: state.updatePodData}))
7+
const podData = usePodDataStore(state => state.podData)
88

99
const receiveColumnTabItems = [
1010
{

0 commit comments

Comments
 (0)