fix: apply some fixes

Author: maximka76667

electron-app/main.js

@@ -116,11 +116,11 @@ app.on("window-all-closed", () => {
 });
 
 // Cleanup before app quits
-app.on("before-quit", () => {
-  // Stop backend process gracefully
-  stopBackend();
-  // Stop packet sender process gracefully
-  stopPacketSender();
+app.on("before-quit", (e) => {
+  e.preventDefault();
+  Promise.all([stopBackend(), stopPacketSender()])
+    .catch((error) => logger.electron.error("Error during shutdown:", error))
+    .finally(() => app.exit());
 });
 
 // Handle uncaught exceptions globally

electron-app/preload.js

@@ -37,6 +37,10 @@ contextBridge.exposeInMainWorld("electronAPI", {
   // Open folder selection dialog
   selectFolder: () => ipcRenderer.invoke("select-folder"),
   // Receive log message from backend
-  onLog: (callback) =>
-    ipcRenderer.on("log", (_event, value) => callback(value)),
+  onLog: (callback) => {
+    const listener = (_event, value) => callback(value);
+    ipcRenderer.removeAllListeners("log");
+    ipcRenderer.on("log", listener);
+    return () => ipcRenderer.removeListener("log", listener);
+  },
 });

electron-app/src/config/__tests__/updateTomlValue.test.js

@@ -164,4 +164,45 @@ key2 = "value2"`;
       0
     );
   });
+
+  it("should not corrupt a [section]-like line inside a multiline string", () => {
+    const toml = `[app]
+note = """
+[not-a-section]
+just text
+"""
+name = "old"`;
+
+    const result = updateTomlValue(toml, "app", "name", "new");
+
+    expect(result).toContain('name = "new"');
+    expect(result).toContain("[not-a-section]");
+  });
+
+  it("should not update a key inside a multiline string", () => {
+    const toml = `[app]
+note = """
+name = "inside multiline"
+"""
+name = "real"`;
+
+    const result = updateTomlValue(toml, "app", "name", "updated");
+
+    expect(result).toContain('name = "updated"');
+    expect(result).toContain('name = "inside multiline"');
+    expect(result.indexOf('name = "inside multiline"')).toBeLessThan(
+      result.indexOf('name = "updated"')
+    );
+  });
+
+  it("should handle a multiline string that opens and closes on the same line", () => {
+    const toml = `[app]
+note = """single line multiline"""
+name = "old"`;
+
+    const result = updateTomlValue(toml, "app", "name", "new");
+
+    expect(result).toContain('name = "new"');
+    expect(result).toContain('note = """single line multiline"""');
+  });
 });

electron-app/src/config/configManager.js

@@ -21,18 +21,30 @@ import { logger } from "../utils/logger.js";
  * const updated = updateTomlValue(content, "database", "host", "192.168.1.1");
  */
 function updateTomlValue(tomlContent, section, key, newValue) {
+  const lineEnding = tomlContent.includes("\r\n") ? "\r\n" : "\n";
   // Split content into lines for processing
   const lines = tomlContent.split(/\r?\n/);
   // Track current section while iterating
   let currentSection = null;
   // Flag to track if update was successful
   let updated = false;
+  // Track if we're inside a multiline string
+  let inMultilineString = false;
 
   // Process each line
   const result = lines.map((line) => {
     // Get trimmed version for parsing
     const trimmed = line.trim();
 
+    // Track multiline string boundaries (""" or ''')
+    const tripleDoubleQuotes = (line.match(/"""/g) || []).length;
+    const tripleSingleQuotes = (line.match(/'''/g) || []).length;
+    if (tripleDoubleQuotes % 2 !== 0 || tripleSingleQuotes % 2 !== 0) {
+      inMultilineString = !inMultilineString;
+      return line;
+    }
+    if (inMultilineString) return line;
+
     // Track current section
     const sectionMatch = trimmed.match(/^\[([^\]]+)\]$/);
     if (sectionMatch) {
@@ -104,7 +116,7 @@ function updateTomlValue(tomlContent, section, key, newValue) {
   }
 
   // Join lines back into string
-  return result.join("\n");
+  return result.join(lineEnding);
 }
 
 /**

electron-app/src/processes/backend.js

@@ -88,8 +88,7 @@ async function startBackend(logWindow = null) {
     backendProcess.stderr.on("data", (data) => {
       const errorMsg = data.toString().trim();
       logger.backend.error(errorMsg);
-      // Store the last error message
-      lastBackendError = errorMsg;
+      if (errorMsg) lastBackendError = errorMsg;
 
       // Send error message to log window
       if (currentLogWindow && !currentLogWindow.isDestroyed()) {
@@ -111,9 +110,9 @@ async function startBackend(logWindow = null) {
     // Handle process exit
     backendProcess.on("close", (code) => {
       logger.backend.info(`Backend process exited with code ${code}`);
-      // Show error dialog if process crashed (non-zero exit code)
+      clearTimeout(startupTimer);
+
       if (code !== 0 && code !== null) {
-        // Build error message with actual error details
         let errorMessage = `Backend exited with code ${code}`;
 
         if (lastBackendError) {
@@ -123,15 +122,16 @@ async function startBackend(logWindow = null) {
         }
 
         dialog.showErrorBox("Backend Crashed", errorMessage);
-        // Clear error message after showing
         lastBackendError = null;
+        backendProcess = null;
+        return reject(new Error(errorMessage));
       }
 
       backendProcess = null;
     });
 
     // If the backend didn't fail in this period of time, resolve the promise
-    setTimeout(() => {
+    const startupTimer = setTimeout(() => {
       resolve(backendProcess);
     }, 2000);
   });

electron-app/src/windows/mainWindow.js

@@ -81,6 +81,8 @@ function loadView(view) {
   // Construct path to view HTML file
   const viewPath = path.join(appPath, "renderer", view, "index.html");
 
+  if (!mainWindow || mainWindow.isDestroyed()) return;
+
   // Check if view file exists
   if (fs.existsSync(viewPath)) {
     // Load the view HTML file

frontend/testing-view/src/features/charts/components/ChartLegend.tsx

@@ -6,15 +6,15 @@ import { ChartSettings } from "./ChartSettings";
 interface ChartLegendProps {
   chartId: string;
   series: WorkspaceChartSeries[];
-  disabledIndices: Set<number>;
-  onToggle: (index: number) => void;
-  onRemove: (variable: string, index: number) => void;
+  disabledVariables: Set<string>;
+  onToggle: (seriesKey: string) => void;
+  onRemove: (variable: string) => void;
 }
 
 export const ChartLegend = ({
   chartId,
   series,
-  disabledIndices,
+  disabledVariables,
   onToggle,
   onRemove,
 }: ChartLegendProps) => (
@@ -25,9 +25,9 @@ export const ChartLegend = ({
         className="border-border flex items-center overflow-hidden rounded-md border shadow-sm transition-transform active:scale-95"
       >
         <button
-          onClick={() => onToggle(i)}
+          onClick={() => onToggle(p.variable)}
           className={`flex items-center gap-2 px-2.5 py-1 text-[10px] font-bold uppercase transition-colors ${
-            disabledIndices.has(i)
+            disabledVariables.has(p.variable)
               ? "bg-muted text-muted-foreground grayscale"
               : "bg-background text-foreground hover:bg-accent"
           }`}
@@ -39,7 +39,8 @@ export const ChartLegend = ({
           {p.variable}
         </button>
         <button
-          onClick={() => onRemove(p.variable, i)}
+          title={`Remove variable ${p.variable}`}
+          onClick={() => onRemove(p.variable)}
           className="border-border text-muted-foreground hover:bg-destructive/10 hover:text-destructive h-full border-l px-1.5 py-1 transition-colors"
         >
           <X className="h-3 w-3" />

frontend/testing-view/src/features/charts/components/ChartSurface.tsx

@@ -14,14 +14,14 @@ import { createTooltipPlugin } from "./tooltipPlugin";
 interface ChartSurfaceProps {
   chartId: string;
   series: WorkspaceChartSeries[];
-  disabledIndices: Set<number>;
+  disabledVariables: Set<string>;
 }
 
 // IMPORTANT: This component was almost completely vibe-coded
 // It could provoke bugs, thus it could be improved
 
 export const ChartSurface = memo(
-  ({ chartId, series, disabledIndices }: ChartSurfaceProps) => {
+  ({ chartId, series, disabledVariables }: ChartSurfaceProps) => {
     const containerRef = useRef<HTMLDivElement>(null);
     const uplotRef = useRef<uPlot | null>(null);
     const historyRef = useRef<any[]>([]);
@@ -72,13 +72,13 @@ export const ChartSurface = memo(
     useEffect(() => {
       if (uplotRef.current) {
         // Index in series starts at 1 because 0 is the X-axis
-        series.forEach((_, i) => {
+        series.forEach((s, i) => {
           const seriesIdx = i + 1;
-          const isVisible = !disabledIndices.has(i);
+          const isVisible = !disabledVariables.has(s.variable);
           uplotRef.current?.setSeries(seriesIdx, { show: isVisible });
         });
       }
-    }, [disabledIndices, series]);
+    }, [disabledVariables, series]);
 
     const handleDoubleClick = () => {
       setIsZooming(false);

frontend/testing-view/src/features/charts/components/TelemetryChart.tsx

@@ -41,25 +41,25 @@ export const TelemetryChart = ({
   const removeChart = useStore((s) => s.removeChart);
   const removeSeries = useStore((s) => s.removeSeriesFromChart);
 
-  const [disabledIndices, setDisabledIndices] = useState<Set<number>>(
+  const [disabledVariables, setDisabledVariables] = useState<Set<string>>(
     new Set(),
   );
 
-  const toggleSeries = (index: number) => {
-    setDisabledIndices((prev) => {
+  const toggleSeries = (variable: string) => {
+    setDisabledVariables((prev) => {
       const next = new Set(prev);
-      if (next.has(index)) next.delete(index);
-      else next.add(index);
+      if (next.has(variable)) next.delete(variable);
+      else next.add(variable);
       return next;
     });
   };
 
-  const handleRemoveSeries = (variable: string, index: number) => {
+  const handleRemoveSeries = (variable: string) => {
     if (!activeWorkspaceId) return;
     removeSeries(activeWorkspaceId, id, variable);
-    setDisabledIndices((prev) => {
+    setDisabledVariables((prev) => {
       const next = new Set(prev);
-      next.delete(index);
+      next.delete(variable);
       return next;
     });
   };
@@ -91,6 +91,7 @@ export const TelemetryChart = ({
 
         {/* Delete Button */}
         <button
+          title="Remove chart"
           onClick={() =>
             activeWorkspaceId && removeChart(activeWorkspaceId, id)
           }
@@ -103,15 +104,15 @@ export const TelemetryChart = ({
       <ChartLegend
         chartId={id}
         series={series}
-        disabledIndices={disabledIndices}
+        disabledVariables={disabledVariables}
         onToggle={toggleSeries}
-        onRemove={(v, i) => handleRemoveSeries(v, i)}
+        onRemove={handleRemoveSeries}
       />
 
       <ChartSurface
         chartId={id}
         series={series}
-        disabledIndices={disabledIndices}
+        disabledVariables={disabledVariables}
       />
     </div>
   );

frontend/testing-view/src/features/charts/store/chartsSlice.ts

@@ -33,6 +33,8 @@ export interface ChartsSlice {
     variable: string,
   ) => void;
 
+  clearCharts: () => void;
+
   /** Sets new buffer size or history limit for a chart. */
   setChartHistoryLimit: (
     workspaceId: string,