Fix Enums

Author: JFisica

control-station/src/components/BoolIndicator/ImdIndicator.tsx

@@ -12,22 +12,17 @@ export const ImdIndicator = () => {
     const podData = usePodDataStore((state) => state.podData);
     const lostConnection = useContext(LostConnectionContext);
 
-    const [hasReceivedData, setHasReceivedData] = useState(false);
-    const [IsImdOk, setVariant] = useState(true); 
+    const [IsImdOk, setVariant] = useState<boolean | null>(true); 
+
+    const hvscuBoard = podData.boards.find(board => board.name === 'HVSCU');
+    const hasReceivedData = hvscuBoard?.packets.some(packet => packet.count > 0) || false;
 
     useGlobalTicker(() => {
-        const hvscuBoard = podData.boards.find(board => board.name === 'HVSCU');
-        const hasReceivedPackets = hvscuBoard?.packets.some(packet => packet.count > 0) || false;
-        
         const currentValue = getValue();
         setVariant(currentValue);
-        
-        if (hasReceivedPackets && !hasReceivedData) {
-            setHasReceivedData(true);
-        }
     });
 
-    const showDisconnected = lostConnection || !hasReceivedData;
+    const showDisconnected = lostConnection || !hasReceivedData || IsImdOk === null;
 
     return (
         <div

control-station/src/components/EnumIndicator/EnumIndicator.tsx

@@ -16,24 +16,18 @@ export const EnumIndicator = memo(({ measurementId, icon }: Props) => {
   const podData = usePodDataStore((state) => state.podData);
   const lostConnection = useContext(LostConnectionContext);
 
-  const [hasReceivedData, setHasReceivedData] = useState(false);
-  const [variant, setVariant] = useState(getValue());
+  const [variant, setVariant] = useState<string | null>(getValue());
+  
+  const boardName = measurementId.split('/')[0];
+  const board = podData.boards.find(b => b.name === boardName);
+  const hasReceivedData = board?.packets.some(packet => packet.count > 0) || false;
 
   useGlobalTicker(() => {
-    const boardName = measurementId.split('/')[0];
-    
-    const board = podData.boards.find(b => b.name === boardName);
-    const hasReceivedPackets = board?.packets.some(packet => packet.count > 0) || false;
-    
     const currentValue = getValue();
     setVariant(currentValue);
-
-    if (hasReceivedPackets && !hasReceivedData) {
-      setHasReceivedData(true);
-    }
   });
 
-  const showDisconnected = lostConnection || !hasReceivedData;
+  const showDisconnected = lostConnection || !hasReceivedData || variant === null;
   const state = showDisconnected ? "DISCONNECTED" : variant;
 
   return (

control-station/src/components/EnumIndicator/VehicleState.tsx

@@ -15,22 +15,17 @@ export const VehicleState = () => {
     const podData = usePodDataStore((state) => state.podData);
     const lostConnection = useContext(LostConnectionContext);
 
-    const [hasReceivedData, setHasReceivedData] = useState(false);
     const [generalState, setGeneralState] = useState('FAULT');
     const [operationalState, setOperationalState] = useState('FAULT');
 
+    const vcuBoard = podData.boards.find(board => board.name === 'VCU');
+    const hasReceivedData = vcuBoard?.packets.some(packet => packet.count > 0) || false;
+
     useGlobalTicker(() => {
-        const vcuBoard = podData.boards.find(board => board.name === 'VCU');
-        const hasReceivedPackets = vcuBoard?.packets.some(packet => packet.count > 0) || false;
-        
         const currentGeneralState = generalStateMeasurement();
         const currentOperationalState = operationalStateMeasurement();
         setGeneralState(currentGeneralState);
         setOperationalState(currentOperationalState);
-        
-        if (hasReceivedPackets && !hasReceivedData) {
-            setHasReceivedData(true);
-        }
     });
 
     const showDisconnected = lostConnection || !hasReceivedData;

control-station/src/pages/VehiclePage/MainPage/MainPageModules/BrakeState.tsx

@@ -11,19 +11,14 @@ export const BrakeState = () => {
     const podData = usePodDataStore((state) => state.podData);
     const lostConnection = useContext(LostConnectionContext);
 
-    const [hasReceivedData, setHasReceivedData] = useState(false);
     const [ReedsState, setVariant] = useState(false);
 
+    const vcuBoard = podData.boards.find(board => board.name === 'VCU');
+    const hasReceivedData = vcuBoard?.packets.some(packet => packet.count > 0) || false;
+
     useGlobalTicker(() => {
-        const vcuBoard = podData.boards.find(board => board.name === 'VCU');
-        const hasReceivedPackets = vcuBoard?.packets.some(packet => packet.count > 0) || false;
-        
         const currentValue = getValue();
         setVariant(currentValue);
-
-        if (hasReceivedPackets && !hasReceivedData) {
-            setHasReceivedData(true);
-        }
     });
 
     const showDisconnected = lostConnection || !hasReceivedData;