Merge pull request #213 from HyperloopUPV-H8/ethernet-view/fix-uint32

msanlli · web-flow · commit 732c5b1a5f30 · 2025-02-16T17:59:33.000+01:00
Solved bug with uint32 orders
diff --git a/ethernet-view/src/components/OrdersContainer/Orders/BoardOrders/OrderForm/Fields/Field/validation.ts b/ethernet-view/src/components/OrdersContainer/Orders/BoardOrders/OrderForm/Fields/Field/validation.ts
@@ -72,11 +72,13 @@ function stringIsNumber(valueStr: string, numberType: NumericType): boolean {
 }
 
 function checkUnsignedIntegerOverflow(value: number, bits: number): boolean {
-    return value >= 0 && value < 1 << bits; //FIXME: añadir unos
+    return value >= 0 && value <= Math.pow(2, bits) - 1;
 }
 
 function checkSignedIntegerOverflow(value: number, bits: number): boolean {
-    return value >= -1 << (bits - 1) && value < 1 << (bits - 1);
+    const min = -Math.pow(2, bits - 1);
+    const max = Math.pow(2, bits - 1) - 1;
+    return value >= min && value <= max;
 }
 
 function checkFloatOverflow(value: number): boolean {

Original file line number	Diff line number	Diff line change
`@@ -72,11 +72,13 @@ function stringIsNumber(valueStr: string, numberType: NumericType): boolean {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`function checkUnsignedIntegerOverflow(value: number, bits: number): boolean {`
`75`		`- return value >= 0 && value < 1 << bits; //FIXME: añadir unos`
	`75`	`+ return value >= 0 && value <= Math.pow(2, bits) - 1;`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`function checkSignedIntegerOverflow(value: number, bits: number): boolean {`
`79`		`- return value >= -1 << (bits - 1) && value < 1 << (bits - 1);`
	`79`	`+ const min = -Math.pow(2, bits - 1);`
	`80`	`+ const max = Math.pow(2, bits - 1) - 1;`
	`81`	`+ return value >= min && value <= max;`
`80`	`82`	`}`
`81`	`83`
`82`	`84`	`function checkFloatOverflow(value: number): boolean {`