fix(backend, TCP): remove unused var

Author: JavierRibaldelRio

backend/cmd/setup_transport.go

@@ -64,16 +64,19 @@ func configureTCPClientTransport(
 	i := 0 // count
 
 	// map of remote server addresses to transport targets for boards not present in vehicle config
-	serverTargets := make(map[string]abstraction.TransportTarget)
 	for _, board := range podData.Boards {
+
+		// Skip boards not in config.Vehicle.Boards to avoid unnecessary TCP clients and potential connection issues
 		if !common.Contains(config.Vehicle.Boards, board.Name) {
-			serverTargets[fmt.Sprintf("%s:%d", adj.Info.Addresses[board.Name], adj.Info.Ports[TcpClient])] = abstraction.TransportTarget(board.Name)
 			continue
 		}
+
+		// Resolve local TCP client address with incremental port to avoid conflicts
 		backendTcpClientAddr, err := net.ResolveTCPAddr("tcp", fmt.Sprintf("%s:%d", adj.Info.Addresses[BACKEND], adj.Info.Ports[TcpClient]+uint16(i)))
 		if err != nil {
-			panic("Failed to resolve local backend TCP client address")
+			trace.Fatal().Err(err).Msg("failed to resolve local backend TCP client address: " + err.Error())
 		}
+
 		// Create TCP client config with custom parameters from config
 		clientConfig := tcp.NewClientConfig(backendTcpClientAddr)
 

backend/pkg/transport/transport.go

@@ -55,7 +55,7 @@ func (transport *Transport) HandleClient(config tcp.ClientConfig, remote string)
 	client := tcp.NewClient(remote, config, transport.logger)
 	clientLogger := transport.logger.With().Str("remoteAddress", remote).Logger()
 	defer clientLogger.Warn().Msg("abort connection")
-	var hasConnected = false
+	hasConnected := false
 
 	for {
 		conn, err := client.Dial()
@@ -126,7 +126,8 @@ func (transport *Transport) handleTCPConn(conn net.Conn) error {
 		return err
 	}
 
-	connectionLogger := transport.logger.With().Str("remoteAddress", conn.RemoteAddr().String()).Str("target", string(target)).Logger()
+	connectionLogger := transport.logger.With().
+		Str("remoteAddress", conn.RemoteAddr().String()).Str("target", string(target)).Logger()
 	connectionLogger.Info().Msg("new connection")
 
 	if err := transport.rejectIfConnectedTCPConn(target, conn, connectionLogger); err != nil {
@@ -143,6 +144,7 @@ func (transport *Transport) handleTCPConn(conn net.Conn) error {
 	cleanupConn := transport.registerTCPConn(target, conn, connectionLogger)
 	defer cleanupConn()
 
+	// Notify vehicle of connection status.
 	transport.api.ConnectionUpdate(target, true)
 	defer transport.api.ConnectionUpdate(target, false)