Skip to content

Commit a5e6707

Browse files
committed
optimise chart canvas and legend
1 parent 42c07b3 commit a5e6707

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

ethernet-view/src/components/ChartMenu/ChartElement/ChartCanvas/ChartCanvas.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export const ChartCanvas = ({ measurementsInChart }: Props) => {
5959
if(chart.current)
6060
chartDataSeries.current.set(measurement.id, [chart.current.addLineSeries({color: measurement.color}), measurement.getUpdate]);
6161
});
62-
}, [measurementsInChart.length])
62+
})
6363

6464
useGlobalTicker(() => {
6565
const now = Date.now() / 1000 as UTCTimestamp;

ethernet-view/src/components/ChartMenu/ChartElement/ChartElement.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ type Props = {
1515
// React component that keeps the chart render and measurements represented on it.
1616
export const ChartElement = memo(({ chartId, initialMeasurementId, removeChart }: Props) => {
1717

18-
console.log("ChartElement rendered")
19-
2018
const getNumericMeasurementInfo = useMeasurementsStore(state => state.getNumericMeasurementInfo);
2119
const initialMeasurement = getNumericMeasurementInfo(initialMeasurementId);
2220

2321
const [measurementsInChart, setMeasurementsInChart] = useState([initialMeasurement]);
2422

2523
const addMeasurementToChart = (measurement: NumericMeasurementInfo) => {
26-
setMeasurementsInChart([...measurementsInChart, measurement]);
24+
if(!measurementsInChart.some(measurementInChart => measurementInChart.id === measurement.id)) {
25+
setMeasurementsInChart([...measurementsInChart, measurement]);
26+
}
2727
}
2828

2929
const removeMeasurementFromChart = useCallback((measurementId: MeasurementId) => {

ethernet-view/src/components/ChartMenu/ChartMenu.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ type Props = {
1919

2020
export const ChartMenu = memo(({ sidebarSections }: Props) => {
2121

22-
console.log("ChartMenu rendered")
23-
2422
const getNumericMeasurementInfo = useMeasurementsStore((state) => state.getNumericMeasurementInfo);
2523

2624
const [charts, setCharts] = useState<ChartInfo[]>([]);

0 commit comments

Comments
 (0)