fix(backend, transport, test): wire encoder for packet id 100 and wait for transport connection update in tests

Author: vasyl-ks

backend/pkg/transport/transport_test.go

@@ -89,12 +89,17 @@ type MockBoardServer struct {
 
 func NewMockBoardServer(address string) *MockBoardServer {
 	logger := zerolog.Nop()
+
+	enc := presentation.NewEncoder(binary.BigEndian, logger)
+    dec := presentation.NewDecoder(binary.BigEndian, logger)
+    wireTestPacketCodec(enc, dec, abstraction.PacketId(100))
+
 	return &MockBoardServer{
 		address:     address,
 		connections: make([]net.Conn, 0),
 		packetsRecv: make([]abstraction.Packet, 0),
-		encoder:     presentation.NewEncoder(binary.BigEndian, logger),
-		decoder:     presentation.NewDecoder(binary.BigEndian, logger),
+		encoder:     enc,
+		decoder:     dec,
 	}
 }
 
@@ -224,9 +229,14 @@ func (s *MockBoardServer) GetConnectionCount() int {
 func createTestTransport(t *testing.T) (*Transport, *TestTransportAPI) {
 	logger := zerolog.New(zerolog.NewTestWriter(t)).With().Timestamp().Logger()
 
+	enc := presentation.NewEncoder(binary.BigEndian, logger)
+    dec := presentation.NewDecoder(binary.BigEndian, logger)
+    wireTestPacketCodec(enc, dec, abstraction.PacketId(100))
+
+
 	transport := NewTransport(logger).
-		WithEncoder(presentation.NewEncoder(binary.BigEndian, logger)).
-		WithDecoder(presentation.NewDecoder(binary.BigEndian, logger))
+		WithEncoder(enc).
+		WithDecoder(dec)
 
 	api := NewTestTransportAPI()
 	transport.SetAPI(api)
@@ -255,6 +265,20 @@ func waitForCondition(condition func() bool, timeout time.Duration, message stri
 	return fmt.Errorf("timeout waiting for condition: %s", message)
 }
 
+// test wiring: register a trivial codec for a data packet id.
+func wireTestPacketCodec(enc *presentation.Encoder, dec *presentation.Decoder, id abstraction.PacketId) {
+    dataEnc := data.NewEncoder(binary.BigEndian)
+    dataDec := data.NewDecoder(binary.BigEndian)
+
+    // Empty descriptor = no payload values, just the id header.
+    var desc data.Descriptor
+    dataEnc.SetDescriptor(id, desc)
+    dataDec.SetDescriptor(id, desc)
+
+    enc.SetPacketEncoder(id, dataEnc)
+    dec.SetPacketDecoder(id, dataDec)
+}
+
 // Unit Tests
 func TestTransport_Creation(t *testing.T) {
 	logger := zerolog.Nop()
@@ -307,6 +331,42 @@ func TestTransport_SetTargetIp(t *testing.T) {
 	}
 }
 
+func TestTransport_InvalidInputs(t *testing.T) {
+	transport, _ := createTestTransport(t)
+
+	// Test invalid ID input
+	err := transport.SetIdTarget(0, "")
+	if err == nil {
+		t.Errorf("Expected error for invalid ID input, got nil")
+	}
+
+	// Test invalid IP input
+	err = transport.SetTargetIp("", "")
+	if err == nil {
+		t.Errorf("Expected error for invalid IP input, got nil")
+	}
+}
+
+func TestTransport_RemoveTargets(t *testing.T) {
+	transport, _ := createTestTransport(t)
+
+	// Add entries
+	transport.SetIdTarget(100, "TEST_BOARD")
+	transport.SetTargetIp("192.168.1.100", "TEST_BOARD")
+
+	// Remove entries
+	delete(transport.idToTarget, 100)
+	delete(transport.ipToTarget, "192.168.1.100")
+
+	// Verify removal
+	if _, exists := transport.idToTarget[100]; exists {
+		t.Errorf("Expected ID 100 to be removed, but it still exists")
+	}
+	if _, exists := transport.ipToTarget["192.168.1.100"]; exists {
+		t.Errorf("Expected IP 192.168.1.100 to be removed, but it still exists")
+	}
+}
+
 // Integration Tests
 func TestTransport_ClientServerConnection(t *testing.T) {
 	transport, api := createTestTransport(t)
@@ -437,7 +497,8 @@ func TestTransport_PacketSending(t *testing.T) {
 
 	// Wait for connection
 	err = waitForCondition(func() bool {
-		return mockBoard.GetConnectionCount() > 0
+    	updates := api.GetConnectionUpdates()
+    	return len(updates) > 0 && updates[len(updates)-1].Target == target && updates[len(updates)-1].IsConnected
 	}, 2*time.Second, "Should establish connection")
 	if err != nil {
 		t.Fatal(err)