fix: prevent key bindings if a dialog is open

Author: maximka76667

frontend/testing-view/src/features/keyBindings/hooks/useGlobalKeyBindings.ts

@@ -18,6 +18,9 @@ export const useGlobalKeyBindings = () => {
 
   useEffect(() => {
     const handleKeyPress = (e: KeyboardEvent) => {
+      // Skip if a dialog is open
+      if (document.querySelector('[role="dialog"]')) return;
+
       // Skip if user is typing in an input/textarea/contenteditable
       if (
         e.target instanceof HTMLInputElement ||
@@ -46,25 +49,16 @@ export const useGlobalKeyBindings = () => {
       bindings.forEach((binding) => {
         // Handle special built-in commands
         if (binding.commandId === START_LOGGER_COMMAND_ID) {
-          logger.testingView.log(
-            `Executing Start Logger via key binding [${key}]`,
-          );
           startLogging();
           return;
         }
 
         if (binding.commandId === STOP_LOGGER_COMMAND_ID) {
-          logger.testingView.log(
-            `Executing Stop Logger via key binding [${key}]`,
-          );
           stopLogging();
           return;
         }
 
         if (binding.commandId === TOGGLE_LOGGER_COMMAND_ID) {
-          logger.testingView.log(
-            `Executing Toggle Logger via key binding [${key}]`,
-          );
           toggleLogging();
           return;
         }

frontend/testing-view/src/hooks/useLogger.ts

@@ -1,10 +1,10 @@
-import { socketService } from "@workspace/core";
+import { logger, socketService } from "@workspace/core";
 import { useTopic } from "@workspace/ui/hooks";
 import { useEffect, useState } from "react";
 import { config } from "../../config";
 import { useStore } from "../store/store";
-import type { BoardName } from "../types/data/board";
 import type { LoggerStatus } from "../types/common/logger";
+import type { BoardName } from "../types/data/board";
 import type { TelemetryCatalogItem } from "../types/data/telemetryCatalogItem";
 
 // Shared singleton state across all useLogger instances
@@ -24,7 +24,9 @@ export function useLogger() {
 
   useEffect(() => {
     listeners.add(setStatus);
-    return () => { listeners.delete(setStatus); };
+    return () => {
+      listeners.delete(setStatus);
+    };
   }, []);
 
   const log = (enable: boolean) => {
@@ -68,12 +70,14 @@ export function useLogger() {
   const startLogging = () => {
     if (sharedStatus === "recording" || sharedStatus === "loading") return;
     const vars = getVariables();
+    logger.testingView.log("Starting logger...");
     socketService.post("logger/variables", vars);
     log(true);
   };
 
   const stopLogging = () => {
     if (sharedStatus !== "recording") return;
+    logger.testingView.log("Stopping logger...");
     log(false);
   };