Skip to content

Commit db40d44

Browse files
committed
fix(backend, transport, test): stop using testing logger in transport
- use zerolog.Nop() in createTestTransport - avoid panic when background goroutines log after tests
1 parent b456187 commit db40d44

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

backend/pkg/transport/transport_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,8 +227,10 @@ func (s *MockBoardServer) GetConnectionCount() int {
227227

228228
// Test utilities
229229
func createTestTransport(t *testing.T) (*Transport, *TestTransportAPI) {
230-
logger := zerolog.New(zerolog.NewTestWriter(t)).With().Timestamp().Logger()
231-
230+
// if NewTestWriter(t) is used: background goroutines may log after the test ends and cause a panic
231+
//logger := zerolog.New(zerolog.NewTestWriter(t)).With().Timestamp().Logger()
232+
logger := zerolog.New(zerolog.Nop()).With().Timestamp().Logger()
233+
232234
enc := presentation.NewEncoder(binary.BigEndian, logger)
233235
dec := presentation.NewDecoder(binary.BigEndian, logger)
234236
wireTestPacketCodec(enc, dec, abstraction.PacketId(100))

0 commit comments

Comments
 (0)