Skip to content

SCENARIO: An option to split the text into passages should be availab…#390

Draft
Dinalrn wants to merge 3 commits intomainfrom
fix-355
Draft

SCENARIO: An option to split the text into passages should be availab…#390
Dinalrn wants to merge 3 commits intomainfrom
fix-355

Conversation

@Dinalrn
Copy link
Copy Markdown

@Dinalrn Dinalrn commented Mar 24, 2026

…le during glose creation (see #355)

We, [FILL WITH FULL NAMES], hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

@benel
Copy link
Copy Markdown
Member

benel commented Mar 31, 2026

@Dinalrn Thank you for your contribution.

Don't forget to use the Co-authored-by syntax in the commit description to mention your co-authors.

I strongly recommend using Git Fork for the intensive git history rewriting done in IF05.

Copy link
Copy Markdown
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Dinalrn.

Here are a few changes to bring to your scenarios file.

Alors la glose ouverte a les métadonnées
"""
dc_creator: Aurélien Bénel
dc_creator: Aurélien Bénel à
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated edit. To be discarded.

Comment thread frontend/scenarios/create_document.feature Outdated
…le during glose creation (see #355).

Co-authored-by: Dina LOUARN  <dina.louarn@utt.fr>
Co-authored-by: Nathan NICART <nathan.nicart@utt.fr>
Co-authored-by: Magdalena KHIAT <magdalena.khiat@utt.fr>
@benel
Copy link
Copy Markdown
Member

benel commented Apr 8, 2026

Thank you for your contribution @Dinalrn @nathanncrt @magdalenakhiat.

Here is how to use interactive rebase with Git-Fork to fix your Git history and get exactly the 3 required commits complying with naming conventions:

fork-filter.mov
Fork-rebase-start.mov
fork-rebase-done.mp4

magdalenakhiat and others added 2 commits April 21, 2026 14:38
…uring glose creation (see #355).

Co-authored-by: Magdalena KHIAT <magdalena.khiat@utt.fr>
Co-authored-by: Dina LOUARN  <dina.louarn@utt.fr>
Co-authored-by: Nathan NICART <nathan.nicart@utt.fr>
Copy link
Copy Markdown
Member

@benel benel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @Dinalrn @magdalenakhiat @nathanncrt.

As you may have noticed (with the ❌ in continuous integration), your improvement brought a regression (one existing scenario failed). Of course, I cannot integrate your code as long as there is a regression.

On a site note, don't forget to fill in the license agreement. And don't forget to change the state of the pull request from "draft" to "ready for review".

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants