Text edition should have a clear exit option (see #371)#434
Open
Samellaperes wants to merge 2 commits into
Open
Text edition should have a clear exit option (see #371)#434Samellaperes wants to merge 2 commits into
Samellaperes wants to merge 2 commits into
Conversation
Co-authored-by: Othmane Houasli <othmane.houasli@utt.fr>
Samellaperes
force-pushed
the
improvement-371
branch
from
d4e4442 to
7f62ca6
Compare
Author
|
Comme nous n'avons pas eu besoin de modifier le scénario, aucune modification n'étais nécessaire au niveau des tests. Donc nous avons eu uniquement a modifier le editable.js pour rajouter un bouton. Aucune autre fonctionnalité n'a eu besoin d'être modifier. |
benel
changed the title
benel
requested changes
Jun 15, 2026
benel
left a comment
benel
left a comment
Member
There was a problem hiding this comment.
Thank you @Samellaperes and @othmaneutt for your contribution.
Here are a few changes to bring to your files.
| <button | ||
| type="button" | ||
| className="btn btn-success btn-sm mt-1" | ||
| onMouseDown={handleBlur} |
Member
There was a problem hiding this comment.
By firing up this event, handleBlur got invoked twice.
This generates a conflict when you edit and save several times in a row.
benel
force-pushed
the
main
branch
3 times, most recently
from
69f00a6 to
5c4b1c8
Compare
Samellaperes
force-pushed
the
improvement-371
branch
2 times, most recently
from
77ccd49 to
9341d11
Compare
Co-authored-by: othmaneutt <othmane.houasli@utt.fr> Co-authored-by: vanellefotso21-crypto <vanellefotso21@gmail.com>
Samellaperes
force-pushed
the
improvement-371
branch
from
9341d11 to
cacd5ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We, Samella LEUKOUO, FOTSO Vanelle, Othmane Houasli, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.