Remove partner role (#4790)

<!--
Thanks for contributing to Hypha!

Please ensure your contributions pass all necessary linting/testing and
that the appropriate documentation has been updated.
-->

<!--
Describe briefly what your pull request changes. If this is resolving an
issue, please specify below via "Fixes #<Github Issue ID>"
-->
Closes #4719. Migrates all existing partners to coapplicants with
comment privileges and removes the partner role from Hypha. This also
handles swapping partner comment visibility to applicant


## Test Steps
<!-- 
If step does not require manual testing, skip/remove this section.

Give a brief overview of the steps required for a user/dev to test this
contribution. Important things to include:
 - Required user roles for where necessary (ie. "As a Staff Admin...")
- Clear & validatable expected results (ie. "Confirm the submit button
is now not clickable")
- Language that can be understood by non-technical testers if being
tested by users
-->

- [ ] All partner views are removed (update partner, add partner, etc)
- [ ] Comment visibility options show up as expected

**After migrations are ran confirm...**
 - [ ] all active partners are coapplicants w/ comment privileges
 - [ ] the partner role is removed from Hypha
- [ ] activity visibility that previously specified partners (ie.
`partners` or `applicant partners`) are now `applicant`

Author: wes-otf

.github/ISSUE_TEMPLATE/bug_report.md

@@ -48,7 +48,6 @@ A clear and concise description of what you expected to happen.
 - Staff
 - Applicants
 - Reviewers
-- Partners
 - Developers
 - General public
 

.github/ISSUE_TEMPLATE/enhancement-request.md

@@ -50,7 +50,6 @@ Add any other context or screenshots about the feature request here.
 - Staff
 - Applicants
 - Reviewers
-- Partners
 - Developers
 - General public
 

.github/ISSUE_TEMPLATE/feature_request.md

@@ -50,7 +50,6 @@ Add any other context or screenshots about the feature request here.
 - Staff
 - Applicants
 - Reviewers
-- Partners
 - Developers
 - General public
 

.github/ISSUE_TEMPLATE/scoping_review_form.md

@@ -38,7 +38,6 @@ Add any other context or screenshots about the feature request here.
 - Staff
 - Applicants
 - Reviewers
-- Partners
 - Developers
 - General public
 

docs/references/glossary.md

@@ -66,8 +66,5 @@
 **Approver**
 :   an individual, usually member of staff, who can authorize a contract or payment request
 
-**Partner**
-:   For OTF, in the application phase, "partner" could view the application but is unable to submit a review and could submit payment requests. This role can see, edit, and communicate about a specific application.
-
 **Finance**
 :   role for staff with finance related functions. In Hypha they have dashboard to enable approval of invoices.

docs/references/user-roles.md

@@ -12,7 +12,6 @@ For example, system administrators could adjust the administrative access or per
 Hypha comes with the following user roles that has special permissions:
 
 - [Staff](#staff)
-- [Partner](#partner)
 - [Reviewer](#reviewer)
 - [Applicant](#applicant)
 - [Additional roles](#additional-roles)
@@ -28,34 +27,13 @@ Staff can:
 * Modify roles for other users
 * Set up applications (this means creating Forms, Funds, and Rounds
 * View applications/submissions
-* Give other users (ie Reviewers, Partners) access to submissions
+* Give other users (ie. Reviewers, Co-Applicants) access to submissions
 * Review submissions
 * Draft and send correspondence
 * Write a comment to applicants and other users on the platform
 
 Account created by **Staff** & assigned to either "Fund" or specific application(s)
 
-## Partner
-
-The **Partner** role could be access, edit, and communicate about a specific application they are assigned to. This role could be accessed when two or more people are working together on a single application; one applicant gets **Applicant** role, and additional applicants get this role. OTF use the partner role for fellowship host organizations, service providers, etc.
-
-A **Partner can**:
-
-* View, edit, and communicate about a specific application
-* Used when two or more people are working together on an application; one applicant gets **Applicant** role, and additional applicants get this role
-
-> ℹ️ _This role is created by Staff and associated with a specific application_
-
-The **Partner** role could be access, edit, and communicate about a specific application they are assigned to. OTF use the partner role for fellowship host organizations, service providers, etc.
-
-The Partner could only review applications that has been assigned to them. Applications assigned to the Partner are available on their dashboard.
-
-![](../assets/partner_dashboard_assign_submission.png)
-
-The Partner role could be associated or assigned to an application by clicking on Partner button in the **Actions to take** > Assign.
-
-![](../assets/submission_how-to-assign-partner.png)
-
 ## Reviewer
 
 The **Reviewer** role has their own dashboard and can submit reviews. OTF's Advisory Council Members are often assigned the 'Reviewer' role.

docs/setup/administrators/configuration.md

@@ -219,7 +219,7 @@ Staff e-mail domain. Used for OAUTH2 whitelist default value and staff account c
 
 ----
 
-Should staff identities be obscured from Applicants & Partners (ie. comments will be ORG_LONG_NAME rather than "John Doe").
+Should staff identities be obscured from Applicants (ie. comments will be ORG_LONG_NAME rather than "John Doe").
 
    HIDE_STAFF_IDENTITY = env.bool('HIDE_STAFF_IDENTITY', False)
 

docs/user-guides/creating-a-user-account.md

@@ -28,7 +28,7 @@ The "Add User" form will request your email, name, and role within the platform.
 
 ![](../assets/manage_user-add-user.jpg)
 
-Selecting a role with enable to administrative access within the platform. Commonly used roles within the platform are **Staff**, **Partner**, and **Reviewer**.
+Selecting a role with enable to administrative access within the platform. Commonly used roles within the platform are **Staff** and **Reviewer**.
 
 ![](../assets/manage_user-update-group.jpg)
 

hypha/apply/activity/adapters/activity_feed.py

@@ -38,7 +38,6 @@ class ActivityAdapter(AdapterBase):
         MESSAGES.INVITED_TO_PROPOSAL: _("Invited to submit a proposal"),
         MESSAGES.REVIEWERS_UPDATED: "reviewers_updated",
         MESSAGES.BATCH_REVIEWERS_UPDATED: "batch_reviewers_updated",
-        MESSAGES.PARTNERS_UPDATED: "partners_updated",
         MESSAGES.NEW_REVIEW: _("Submitted a review"),
         MESSAGES.OPENED_SEALED: _("Opened the submission while still sealed"),
         MESSAGES.SCREENING: "handle_screening_statuses",
@@ -89,7 +88,6 @@ def extra_kwargs(self, message_type, source, sources, **kwargs):
             MESSAGES.REVIEW_OPINION,
             MESSAGES.DELETE_REVIEW_OPINION,
             MESSAGES.BATCH_REVIEWERS_UPDATED,
-            MESSAGES.PARTNERS_UPDATED,
             MESSAGES.APPROVE_PROJECT,
             MESSAGES.REQUEST_PROJECT_CHANGE,
             MESSAGES.SEND_FOR_APPROVAL,
@@ -287,18 +285,6 @@ def handle_batch_transition(self, transitions, sources, **kwargs):
                 old_phase=old_phase, source=submission, **kwargs
             )
 
-    def partners_updated(self, added, removed, **kwargs):
-        message = [_("Partners updated.")]
-        if added:
-            message.append(_("Added:"))
-            message.append(", ".join([str(user) for user in added]) + ".")
-
-        if removed:
-            message.append(_("Removed:"))
-            message.append(", ".join([str(user) for user in removed]) + ".")
-
-        return " ".join(message)
-
     def handle_report_frequency(self, config, **kwargs):
         new_schedule = config.get_frequency_display()
         return _(

hypha/apply/activity/adapters/emails.py

@@ -9,7 +9,6 @@
 from django.utils.translation import gettext as _
 
 from hypha.apply.activity import tasks
-from hypha.apply.activity.models import ALL, APPLICANT_PARTNERS, PARTNER
 from hypha.apply.funds.models.co_applicants import (
     CoApplicantProjectPermission,
     CoApplicantRole,
@@ -65,8 +64,6 @@ class EmailAdapter(AdapterBase):
         MESSAGES.READY_FOR_REVIEW: "handle_ready_for_review",
         MESSAGES.REVIEWERS_UPDATED: "handle_ready_for_review",
         MESSAGES.BATCH_REVIEWERS_UPDATED: "handle_batch_ready_for_review",
-        MESSAGES.PARTNERS_UPDATED: "partners_updated_applicant",
-        MESSAGES.PARTNERS_UPDATED_PARTNER: "partners_updated_partner",
         MESSAGES.UPLOAD_CONTRACT: "messages/email/contract_uploaded.html",
         MESSAGES.SUBMIT_CONTRACT_DOCUMENTS: "messages/email/submit_contract_documents.html",
         MESSAGES.CREATED_PROJECT: "messages/email/project_created.html",
@@ -328,10 +325,6 @@ def recipients(self, message_type, source, user, **kwargs):
             related = kwargs.get("related", None)
             return [related.invited_user_email]
 
-        if message_type == MESSAGES.PARTNERS_UPDATED_PARTNER:
-            partners = kwargs["added"]
-            return [partner.email for partner in partners]
-
         if message_type == MESSAGES.APPROVE_PAF:
             from hypha.apply.projects.models.project import ProjectSettings
 
@@ -488,12 +481,6 @@ def recipients(self, message_type, source, user, **kwargs):
                 ).values_list("user__email", flat=True)
                 recipients: List[str] = [source.user.email, *co_applicants]
 
-                if partners := list(source.partners.values_list("email", flat=True)):
-                    if comment.visibility == PARTNER:
-                        recipients = partners
-                    elif comment.visibility in [APPLICANT_PARTNERS, ALL]:
-                        recipients += partners
-
             # Comment handling for Projects
             elif isinstance(source, Project):
                 # co_applciants with Comment permission
@@ -557,23 +544,6 @@ def reviewers(self, source):
             and not reviewer.is_apply_staff
         ]
 
-    def partners_updated_applicant(self, added, removed, **kwargs):
-        if added:
-            return self.render_message(
-                "messages/email/partners_update_applicant.html", added=added, **kwargs
-            )
-
-    def partners_updated_partner(self, added, removed, **kwargs):
-        if added:
-            recipient = kwargs["recipient"]
-            # Pass the user object to render_message rather than the email string
-            recipient_obj = User.objects.get(email__exact=recipient)
-            kwargs["recipient"] = recipient_obj
-
-            return self.render_message(
-                "messages/email/partners_update_partner.html", **kwargs
-            )
-
     def render_message(self, template, **kwargs):
         with language(settings.LANGUAGE_CODE):
             text = render_to_string(template, kwargs, kwargs["request"])