Skip to content

Commit a0d04d0

Browse files
committed
Make the 0028_remove_partner_group migration run both functions.
1 parent ef582f8 commit a0d04d0

1 file changed

Lines changed: 15 additions & 7 deletions

File tree

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,20 @@
11
# Generated by Django 5.2.12 on 2026-03-26 19:48
22

33
from django.db import migrations
4-
from django.contrib.auth.models import Group
54

65

7-
# An edge case that won't apply to most staystems
6+
# An edge case that won't apply to most systems
87
def assigned_review_migrate_from_partners(apps, schema_editor):
98
PARTNER_GROUP_NAME = "Partner"
109
REVIEWER_GROUP_NAME = "Reviewer"
1110

11+
Group = apps.get_model("auth", "Group")
1212
AssignedReviewers = apps.get_model("funds", "AssignedReviewers")
1313

14-
reviewer_id = Group.objects.get(name=REVIEWER_GROUP_NAME).id
14+
try:
15+
reviewer_id = Group.objects.get(name=REVIEWER_GROUP_NAME).id
16+
except Group.DoesNotExist:
17+
return
1518

1619
if id_qs := Group.objects.filter(name=PARTNER_GROUP_NAME).values_list(
1720
"id", flat=True
@@ -21,11 +24,11 @@ def assigned_review_migrate_from_partners(apps, schema_editor):
2124
)
2225

2326

24-
def migrate_partners_to_coapplicants(apps, schema_editor):
27+
def delete_partner_group(apps, schema_editor):
2528
PARTNER_GROUP_NAME = "Partner"
2629

27-
if Group.objects.filter(name=PARTNER_GROUP_NAME).exists():
28-
Group.objects.get(name=PARTNER_GROUP_NAME).delete()
30+
Group = apps.get_model("auth", "Group")
31+
Group.objects.filter(name=PARTNER_GROUP_NAME).delete()
2932

3033

3134
class Migration(migrations.Migration):
@@ -34,4 +37,9 @@ class Migration(migrations.Migration):
3437
("funds", "0133_remove_applicationsubmission_partners"),
3538
]
3639

37-
operations = [migrations.RunPython(migrate_partners_to_coapplicants)]
40+
operations = [
41+
migrations.RunPython(
42+
assigned_review_migrate_from_partners, migrations.RunPython.noop
43+
),
44+
migrations.RunPython(delete_partner_group, migrations.RunPython.noop),
45+
]

0 commit comments

Comments
 (0)