HTML markup issues with application_preview.html

[theskumar]

The form structure in application_preview.html looks odd.

Multiple forms elements.

hypha/hypha/apply/funds/templates/funds/application_preview.html

Lines 15 to 16 in 6ab18e4

	<form id="preview-form-submit" class="form application-form" action="{% url 'funds:submissions:edit' object.id %}" method="POST" enctype="multipart/form-data" novalidate>
	{% csrf_token %}

hypha/hypha/apply/funds/templates/funds/application_preview.html

Lines 41 to 44 in 6ab18e4

	<form id="preview-form-edit" class="form application-form" action="{% url 'funds:submissions:edit' object.id %}" x-data="{ isFormSubmitting: false }" x-on:submit="isFormSubmitting = true">
	{% csrf_token %}
	</form>

The x-data and it's isFormSubmitting is outside of the place where it's used.

hypha/hypha/apply/funds/templates/funds/application_preview.html

Lines 41 to 49 in 6ab18e4

	<form id="preview-form-edit" class="form application-form" action="{% url 'funds:submissions:edit' object.id %}" x-data="{ isFormSubmitting: false }" x-on:submit="isFormSubmitting = true">
	{% csrf_token %}
	</form>
	<div class="form__group">
	<button class="button button--primary" form="preview-form-submit" name="submit" type="submit" :disabled="isFormSubmitting">{% trans "Submit for review" %}</button>
	<button class="button button--secondary" form="preview-form-edit">{% trans "Edit" %}</button>
	</div>

@frjo @wes-otf

[theskumar]

@frjo Found this while working on #4543 , tihs doesn't need to be fixed here, but I think I'm mostly trying to understand the reason for this markup.

[frjo]

Looks like the "Edit" button and extra form should be converted in to a link instead.

<a class="button button--secondary" href="{% url 'funds:submissions:edit' object.id %}">{% trans "Edit" %}</a>

The extra form solution works but is not needed.

[frjo]

This was fixed in #4543.