Render richtext help text on login pages.#4533
Merged
Merged
Conversation
frjo
added
Type: Bug
frjo
commented
May 6, 2025
|
|
||
| {% if field.help_text %} | ||
| <div class="form__help prose prose-sm">{{ field.help_text }}</div> | ||
| <div class="form__help prose prose-sm">{{ field.help_text|safe }}</div> |
Member
Author
There was a problem hiding this comment.
Is this an ok way to solve this? Help text should only come from trusted sources from what I can see.
Member
Author
There was a problem hiding this comment.
Got a "TypeError: argument 'html': 'lazy..proxy' object cannot be converted to 'PyString'" and realised I'm doing it wrong.
Shifted to using "mark_safe()" for this specific help_text instead of messing with rendering of all help_text.
I think this is a more correct approach.
frjo
added
Status: Needs testing
theskumar
approved these changes
May 8, 2025
frjo
removed
Status: Needs testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.