-
Notifications
You must be signed in to change notification settings - Fork 39
Support for themes and new design system. #4543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
251 commits
Select commit
Hold shift + click to select a range
44130a6
Collapse color
theskumar 75b4c7a
Update fieldset
theskumar 04dea91
Update field set
theskumar 24bb008
Update tinymce and choices
theskumar a59e34e
Update skeleton color
theskumar 2760f71
Update export button
theskumar 5ca825a
Update detail page, filter label, text-base-content/80
theskumar dd040eb
Checkbox django-table
theskumar a4db5a6
Fix button--remove
theskumar 2e0494c
formatting
theskumar 51eafc8
Revisions
theskumar 411bfd2
batch action, action-bar, invoices table
theskumar fdc3a82
update
theskumar dcf526f
paf status sidebar
theskumar e29d49b
Added relative timezones to invoice statuses & timezone info to stamp…
wes-otf 36a8595
cleanup list-reveal, modal and invoice-block
theskumar 7ad94e4
Improve co-applicant
theskumar 80ee29c
More buttons
theskumar b7c4194
Fix for tinymce word count
theskumar 2cf8706
Alternate implementation of max-length warning
theskumar c0d2be5
co-applicant & text-gray-500
theskumar ccb657c
Review button
theskumar 6771808
update input to include "time" & "url" type
theskumar bedfb16
Update hypha-grid--two
theskumar bc6a3eb
Account page
theskumar ffd6131
admin bar and tags section
theskumar 9a2385d
update field css and upload button
theskumar 3baf050
Fix fields esp filefield
theskumar 4152333
todo draft badge
theskumar 34aa09f
More badges
theskumar cd07049
border
theskumar 41bcd40
fields, errors and cleanup
theskumar a55d37c
Fix tab text color
theskumar 389c149
sealed submission detail
theskumar 34c2dc1
fix
theskumar 30fa942
Adjustments
theskumar d3d59f3
X - action-bar scss
theskumar fb55b5d
kill status-bar scss
theskumar c2efc70
Screening buttons
theskumar 423b7f6
error display on requested amount input
theskumar 3063989
Upgrade multi-input-field to use alpinejs
theskumar 0310439
Update splitdatetime widget
theskumar f1fbb12
textarea validator
theskumar 1d1a173
Update layout and copy - coapplicant accept
theskumar 2f3c6f0
comment section
theskumar bf9768f
Report frequecy info
theskumar 10b3e70
determination detail
theskumar ff977b2
Show fund description on the form
theskumar 0957c09
Use theme provided primary color
theskumar 8ac7dc6
applicant dashboard should use admin-bar component
theskumar 2e9e92b
New theme for admin bar
theskumar 5cb0fd8
New theme for footer
theskumar 63dfc17
Updates to co-applicant edit form
theskumar e2ad051
Adjustment to form
theskumar caed376
Admin bar + container-constrained
theskumar 8b6f051
update
theskumar a4c2de0
Fix address field js
theskumar 76996b6
updates
theskumar 20860dd
btn-disabled
theskumar acf9acc
update
theskumar d5b7850
Update dashboard round and labs section
theskumar c6f1beb
?? extra markup in table.html
theskumar b8cd6f7
dashbord paf for review
theskumar ce29f0b
Update show application on review and determination
theskumar 15db688
button--link
theskumar 4b013e6
more card-title
theskumar c88a331
project-form page
theskumar d7e54ed
error pages
theskumar dea930a
--span-two
theskumar 2c99b62
hijack-bar
theskumar c6227c2
wrapper--cta-box
theskumar 2b302b6
More wrappers
theskumar 33b848c
Review sidebar updates
theskumar a3d494b
translate
theskumar 10dc1ae
cleanup buttons
theskumar 9c85a70
submissions
theskumar 902b5ae
Nav colors
theskumar 8ffe578
cleanup wrapper and grid
theskumar f9f98aa
submission sealed hero
theskumar 40d83e8
Remove heading--no-margin
theskumar defa6e4
header.scss
theskumar 9f9e195
cleanup
theskumar fed039e
Test passes now
theskumar 47d4328
Remove status-block.scss
theskumar 84f9bd8
cleanup form--error-inline
theskumar 95a3a53
cleanup defailt h6
theskumar ed28a88
Remove _table.scss
theskumar ae89ead
Review List Page update
theskumar daba37d
partner dashboard
theskumar 2fc69f9
Account and 2FA setup page
theskumar df39616
Updates to reporting-frequency
theskumar 0ea4d25
Revert choices.js
theskumar 6399da2
Feedback1: update lang switcher
theskumar fdff17c
2/ update "Coversation" tab to "Comments"
theskumar 01fbdc7
14/ Fix the color success displayed on the checkbox and radio
theskumar da3e87f
8/ bigger search input on project and other tables with search
theskumar 4ec7333
15 / deemphasis primary action card
theskumar 6afa698
11 / rendered answer highlights
theskumar 3654d84
6 / delete button treatment
theskumar 3d9c237
submission more actions icons
theskumar 1714263
6 / clear filter btn update
theskumar 803b8c6
4 / rounded submission tables
theskumar 9847d02
update the pagination button style
theskumar ae977ee
Remove _nav.scss, update is_active logic
theskumar 06273ec
Delete button--secondary, button--white
theskumar 5131faa
Remove button--filters
theskumar 96a281b
Reimplement cookie consent using alpine and localstorage
theskumar 15d02d7
Minor update
theskumar c02f2fd
Merge remote-tracking branch 'origin/main' into themes
theskumar d307621
update requirements
theskumar 56b72c7
Tweaks to co-applicants/project permissions UI
theskumar f026f59
Update table pagination
theskumar bbba637
cleanup
theskumar 7be5fec
Remove _heading.scss
theskumar ade0e73
Remove _button.scss
theskumar 06486a2
table-checkbox mixin
theskumar ea78649
new adminbar using django-cotton
theskumar 34f4765
Revert makefile change
theskumar 4fd54b7
update separator-dot
theskumar f50b4c6
adminbar update existing stuff
theskumar 5599b5f
Use @media for js detection
theskumar 7999c66
Fix alpine stuff
theskumar 8c2ad33
cleanup
theskumar d9cd6ed
Adjust hero header
theskumar 878ca57
update, better link, fixes
theskumar 97a3896
Merge branch 'main' into themes
theskumar e015c78
typography
theskumar 886e303
cleanup base.scss
theskumar b580fd7
Typography round 2
theskumar 7140868
update invalid link page
theskumar 8235d7c
Remove wrapper--small and also update the two-factor pages
theskumar ac4c6ba
Merge branch 'main' into themes
theskumar 5402ce1
Remove review-sidebar__split
theskumar b529e81
clean up submission table child row feature
theskumar b0cdce6
misc updates
theskumar a941a29
.section-header and rounded tables
theskumar 22829eb
Fixup contracting dashboard
theskumar a1bf397
fix filter-bar overflow
theskumar 1dc5bd5
table link formatting
theskumar 0e87d1b
updates
theskumar f061fa9
Footer with theme selector
theskumar 8898e14
Relative time for subitted in tables
theskumar 7e2e9fb
cleanup scss
theskumar ee50c6d
cleanup unused status block views, wrapper--bottom and update open/cl…
theskumar 57c0e0e
staff dashboard table border
theskumar 88b8fe6
doc-block, contract and project detail sections
theskumar 601a02a
Merge remote-tracking branch 'origin/main' into themes
theskumar 2c8c4ab
Icon enhancements
theskumar 1e71b16
More updates to project detail page
theskumar d9de175
more scss variable cleanup
theskumar e3706da
show/hide password feature
theskumar be95d4c
cleanup
theskumar d4892e5
password field - title and translations
theskumar 029f665
Merge remote-tracking branch 'origin/main' into themes
theskumar 5e8f91c
fix comment timeline
theskumar 6775f9c
Remove wrapper__medium
theskumar b7b9db6
Reminder and reminder delete page updates
theskumar ed7463c
Update report form
theskumar a5047b5
Update review sidebar styling
theskumar 554add3
Remove wrapper--outer-space-medium
theskumar f97b31c
update to application detail page
theskumar 11e0429
no-print and manage cookies in footer
theskumar a7c0a18
Fix password show/hide
theskumar 7a5639b
Better handling for users entering long names (#4590)
wes-otf 16354b4
Add Author to report
sandeepsajan0 ca972cf
Show report author and date similar to submissions
sandeepsajan0 5c056ab
Fix updated language
sandeepsajan0 9dbf63b
Minor adjustments to report template.
frjo ee4627d
Merge branch 'feature/gh-4565-report-author' into themes
frjo 6fd9d13
Update SSO login button alignment
theskumar 52b9878
submission all list and table view switcher
theskumar 2a85bea
update container-constrained behaviour
theskumar d091328
Fixes - home deadline, btn-lg and updated at
theskumar 773f236
update typography on the forms
theskumar 1549390
Update to cookiebanner
theskumar 640b715
Update application detail - line-clamp
theskumar 80a2fd6
Update submission-text-cleanup
theskumar 61c0b18
Move more things to tinymce.css
theskumar d3f3c02
Update determination details
theskumar bf9465f
More update detail and submission answer preview
theskumar 9cd50eb
update review detail and list page
theskumar 63d0c56
More relative datetime in tables, using RelativeTimeColumn
theskumar f4733e3
Move prose-cleanup.js up in header
theskumar 1fec1cb
fix application edit typography
theskumar c3b1999
refactor markdown editor css
theskumar 5ee5146
fix dark mode on field field rendering
theskumar ff75689
Remove more .wrapper
theskumar 76c3757
Fix compare view
theskumar 86e8488
Remove rich-text--answers
theskumar 99c5a4a
update user-menu colors
theskumar b539d40
fix container-constrained
theskumar ec50469
new layout.css component
theskumar 0d2fe85
Invoice delete confirmation modal
theskumar ed4c419
New submission revision list view
theskumar b5018f6
Merge remote-tracking branch 'origin/main' into themes
theskumar f84e7b9
tweaks to revision detail view
theskumar ef93dbf
Restrict permission to invite and update co-applicant in archived sub…
sandeepsajan0 2b236d8
update invoice-form page
theskumar 1cd57ba
update review detail
theskumar 22e7e54
fix for update reviewer modal form
theskumar b3503b9
update html-diff.css
theskumar 127c08e
update modal title to use cotton
theskumar 9262aa1
update review opinion delete confirm to dialog
theskumar a139f96
Add steps-sm and apply to status bars
theskumar 1fe4a38
Update daisyui version
theskumar 41daba6
tweak html-diff
theskumar 5962505
fixup
theskumar 346e9bd
fix approval_form_exists
theskumar 5b8ef1b
Fix contracting document row
theskumar 5d60c6d
w-4 h-4 -> size-4
theskumar 78dd501
update project form and it's details
theskumar 324f44a
Hypha theme colours (#4595)
frjo 4546a00
Fix test for active invoices and minot lint fix.
frjo 182ef71
Fix test for dashboard.
frjo de2729b
tweaks to project detail page
theskumar 2b5f019
Base hyphatheme light on corporate.
frjo 3be56e9
Remove transition from detail summary
theskumar 7cafd11
Fix more tests.
frjo 9fa736f
Fix more tests, part 2.
frjo dfb3af0
Fix more tests, part 3.
frjo bc373d4
Adjust theme colours.
frjo a479340
Merge branch 'enhancement/aco-applicant-complete-project' into themes
sandeepsajan0 df0cbc0
Merge remote-tracking branch 'origin/main' into themes
sandeepsajan0 99f0c1e
use alert component for toast
theskumar 9c9d5a5
tweak theme and status bar
theskumar 2ba6ca7
Update the translation cli and fix loader
theskumar de10a48
Update invoice detail + fix activity list attribute error
theskumar 96febbb
invoices -> show rejected
theskumar 5c3cad3
Update hero back links
theskumar 8091241
theme switcher
theskumar fd1395c
port over wmd classes
theskumar 5235155
convert print.scss to print.css
theskumar 4e1813a
Remove rich-text.css
theskumar 7d9814e
update SOW form page
theskumar 350b10f
fix SOW detail
theskumar 7b6d925
Merge remote-tracking branch 'origin/main' into themes
theskumar 2ad64cb
tweak theme and remove more hard-coded colors
theskumar 9cf4b79
reorder theme, fix for theme-switcher
theskumar 2849473
Fix screen decision buttons
theskumar 034b15e
fix broken help-text
theskumar ea8bfc9
remove duplicate variables
theskumar 790f81d
Remove more custom variables
theskumar 2cec1a1
refactor flash-item -> animate-flash
theskumar d2507f7
Fix typography on application submission landing
theskumar a73f0f2
applicant submission delete button
theskumar 0821495
Fix continue editing button
theskumar 8e52a3c
Update display of draft application for applicant
theskumar cb4d30a
update how status is displayed in old table view
theskumar 8c498b0
tweak icon size in alert
theskumar 6c29fca
Implement updated print styles.
frjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,8 +9,8 @@ | |
| __pycache__ | ||
| db.sqlite3 | ||
| media/ | ||
| static/ | ||
| tmp/ | ||
| /static/ | ||
|
|
||
| # Node | ||
| node_modules/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
border-whitelooks like an obsolete color-named class. Isbg-slate-200also (is "slate" a color)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe both are tailwind-isms:
border-whiteand slateThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My assumption is this. In order for themes to fully take effect via a few CSS rules, no colors should be present in any class names. Technically, I guess a theme could set
.border-white { border-color: blue }😱.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I will be updating to more semantic versions. This is reminiscent of old implementation that happens to work ok-ish in the new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Setting border-white to blue is possible, technically, and much easier done by setting theme variable "--color-white: blue".
Instead of doing this, semantic color names should work better for our use case.