Skip to content

Expand co-applicant feature to projects#4552

Merged
frjo merged 9 commits into
mainfrom
enhancement/co-applican-projects
Jun 7, 2025
Merged

Expand co-applicant feature to projects#4552
frjo merged 9 commits into
mainfrom
enhancement/co-applican-projects

Conversation

@sandeepsajan0

@sandeepsajan0 sandeepsajan0 commented May 24, 2025

Copy link
Copy Markdown
Member

Extension of #4492

Added project permission to co-applicant.
image
image

Test Steps

@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review May 26, 2025 12:36
@sandeepsajan0 sandeepsajan0 requested review from frjo, theskumar and wes-otf and removed request for frjo May 26, 2025 12:36
@frjo

frjo commented May 27, 2025

Copy link
Copy Markdown
Member

Works well in my testing. A few observations.

  1. Should this notification maybe say "Co-applicant invited"?

Skärmavbild 2025-05-27 kl  13 52 05


  1. The delete button is a bit easy to click by mistake. Maybe make it a text link so it is a smaller traget? Other ideas?

Skärmavbild 2025-05-27 kl  10 18 16


  1. Do applicants understand what "Project" is? Do we need these fine grained permissions? @wes-otf?

Skärmavbild 2025-05-27 kl  10 18 56

@frjo frjo changed the title Avail co-applicant feature for projects Expand co-applicant feature to projects May 27, 2025
@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels May 27, 2025
@sandeepsajan0

Copy link
Copy Markdown
Member Author

The delete button is a bit easy to click by mistake. Maybe make it a text link so it is a smaller traget? Other ideas?

Text link is a good option, but not alarming enough. Red color button seems a bit more alarming, and having it with a confirm stage/popup might prevent deletion by mistake.
image

Do applicants understand what "Project" is? Do we need these fine grained permissions?

They might not know the whole project thing/process, but they are aware of the new 'Project' tab, and i guess we also send them a mail about project creation.
Actually, that's the reason I used page sections for project permission instead of statuses(even permission names match with section names), because applicants would see all those sections separately, so if they want to show/hide permission of any section, they can just select accordingly. And also added a descriptive help text of how both permissions would work together. It would be great if we can make it more simpler.
image
image
image

@wes-otf

wes-otf commented May 28, 2025

Copy link
Copy Markdown
Contributor

I'll be testing this afternoon! these comments make sense to me though, if we're already presenting with Project verbiage in the tab I think it makes sense to keep it that way, if we felt more clarity was needed we could just say Project Management or something

@sandeepsajan0

Copy link
Copy Markdown
Member Author

@wes-otf I have renamed Read Only to View as you suggested, and keeping the comment for now, we may wait to see the responses, if applicants want everyone to comment then we may later make it default with View.

@frjo I think it is ready to be put on the test.

@wes-otf

wes-otf commented May 30, 2025

Copy link
Copy Markdown
Contributor

This looks good so far! Testing it locally I had a few quick notes but this is great:

  • The co-applicants card should also appear in the projects tab
  • Maybe it would also be useful to add notifications of reports being due/frequency changes to co-applicants with report edit permissions (via a custom function here)
  • I could also see it beneficial to staff to show what user submitted a report/invoice if multiple are on a project

@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jun 2, 2025
@sandeepsajan0

Copy link
Copy Markdown
Member Author

@frjo I have added the co-applicant block to the projects tab as well. We may move forward with this one.

@wes-otf

wes-otf commented Jun 3, 2025

Copy link
Copy Markdown
Contributor

I'll test this on test tomorrow! Looks pretty good from what I can see though, not expecting any issues

@wes-otf

wes-otf commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Testing went well! Last question is if the project already exists can project_permissions be included in the invite form too? Just so applicants don't have to invite then go back & edit co-applicant permissions once the user accepts if they want them to have project permissions.

Other than that this is ready for merge I think!

@wes-otf wes-otf removed the Status: Needs testing Tickets that need testing/qa label Jun 5, 2025
@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jun 5, 2025
@frjo frjo merged commit 56b31c9 into main Jun 7, 2025
7 checks passed
theskumar added a commit that referenced this pull request Jun 8, 2025
* origin/main:
  Expand co-applicant feature to projects (#4552)
  Set label in project header to "Project lead:" instead of only "Lead:" (#4570)
  Update Django to 4.2.2 and also update other python packages. (#4571)
@theskumar theskumar deleted the enhancement/co-applican-projects branch July 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Tested - approved for live ✅ Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants