Fix overlapping lines in header of submission PDF#4567
Merged
Conversation
sandeepsajan0
approved these changes
Jun 4, 2025
sandeepsajan0
left a comment
Member
There was a problem hiding this comment.
Looks good!
Nice catch on the meta text wrapping. It was happening when any of the meta fields like workflow, round name, lead name, etc., were long enough to wrap it in multiple lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that when the name of the lead on an application is quite long, the "meta" text in the PDF goes over several lines and ends up overlapping (see attached screenshots).
I tracked it down to what I believe is a missing line in
apply/utils/pdfs.py(compared to the similar logic in handlingsplit_titlein the same function).This seemed like a minor change so I didn't create an issue, please let me know if you'd prefer I did that.
Screenshots
Before
After
Test Steps
USE_PROJECTS=Truefor PDF download to work, see PDF download of submission fails when projects are not enabled #4566)