Implemented Cally to replace JQuery based daterangepicker#4568
Conversation
|
@wes-otf I think you are correct. Only five of our own scripts use jQuery and since we removed select2 I believe only the datepicker remain. |
|
@frjo I can open a new issue and do those rewrites so we can toss it once and for all if that sounds good? |
|
@wes-otf Sounds good. The themes PR touch most of these javascripts so best to wait until that is merged. |
533061f to
350b10f
Compare
3fb2bb5 to
5e9b942
Compare
|
Had a bit of a botched merge but I think this should be ready now - also looks like #4597 got overwritten in some of the rebasing/merging so I added it back here |
|
@frjo this was baked into the previous daterangepicker library - I can write up an issue to potentially customize this a bit but even chatting with some staff they said it isn't a big deal especially when you can manually customize the range in the query/search bar |
|
Question should we try get that in the form -> date(time) input as well? EDIT: I think given the browser have native support for datepicker, that might be bit overkill and desired should be considered for future. |
|
I created a separate PR for the async downloads on submission all, #4604. Can we clean upp the commits in this PR a bit? It has become a bit messy. I think the actual code is good to go after that. |
11a732f to
f52c673
Compare
|
Squashed the commits so we should be all good - a bit cleaner now @frjo |
|
@wes-otf Can you take a look at the conflict please. Then we can merge this in. |
f52c673 to
44e19b8
Compare
|
should be good @frjo |
) Fixes HyphaApp#4475. This removes the existing JQuery-based daterangepicker in favor of implementing the DaisyUI supported [Cally](https://wicky.nillia.ms/cally/). This PR builds off of the theme changes of HyphaApp#4543 and requires that to be merged first. Also added functionality that will ensure the calendars auto-populate ranges if date filters exist (for both submission all AND `table_filter_and_search` uses)


Fixes #4475. This removes the existing JQuery-based daterangepicker in favor of implementing the DaisyUI supported Cally. This PR builds off of the theme changes of #4543 and requires that to be merged first.
Also added functionality that will ensure the calendars auto-populate ranges if date filters exist (for both submission all AND
table_filter_and_searchuses)Test Steps
table_filter_and_search.htmlis used (like in/projects/reports/)