Fix submission filters queryset issue#4572
Merged
Merged
Conversation
frjo
approved these changes
Jun 5, 2025
frjo
left a comment
frjo
left a comment
Member
There was a problem hiding this comment.
Works perfectly in my testing, only remove code and fix bug!
I noticed that we have the same issue with the Category filter, show all items if no match. But that is a separate issue for another PR I think.
frjo
added
Type: Bug
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
wes-otf
approved these changes
Jun 9, 2025
theskumar
added a commit
that referenced
this pull request
Jun 11, 2025
* main: Update Django to 4.2.3 and also update other python packages. (#4582) Handle rare event of file uploads having data without id (#4581) Create a json output version of the open calls on the front page. (#4554) Correct project template urls. (#4575) Fix submission filters queryset issue (#4572)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4558
All the code removed in this PR were used for previous/old filter patterns. It was used to update filter datasets dynamically but now we are treating it in a different way and handling those things in submission all view so it is not needed here. It was also messing up with filtered queryset for current implementation.
Now it should show/add/remove 0 submission if filtered query doesn't belong to any submission.
Test Steps