Skip to content

Fix co-applicant permission for Partners, Reviewers, and Community Reviewers #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frjo merged 1 commit into from
Jun 17, 2025
Merged

Fix co-applicant permission for Partners, Reviewers, and Community Reviewers #4583

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions hypha/apply/funds/views/submission_detail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ def dispatch(self, request, *args, **kwargs):
submission = self.get_object()
# If the requesting user submitted the application, return the Applicant view.
# Reviewers may sometimes be applicants as well.
if submission.user == request.user:
# or if requesting user is a co-applicant to application, return the Applicant view.
if (
submission.user == request.user
or submission.co_applicants.filter(user=request.user).exists()
):
return ApplicantSubmissionDetailView.as_view()(request, *args, **kwargs)
if submission.status == DRAFT_STATE:
raise Http404
Expand Down Expand Up @@ -149,7 +153,11 @@ def dispatch(self, request, *args, **kwargs):
)
# If the requesting user submitted the application, return the Applicant view.
# Partners may sometimes be applicants as well.
if submission.user == request.user:
# or if requesting user is a co-applicant to application, return the Applicant view.
if (
submission.user == request.user
or submission.co_applicants.filter(user=request.user).exists()
):
return ApplicantSubmissionDetailView.as_view()(request, *args, **kwargs)
# Only allow partners in the submission they are added as partners
partner_has_access = submission.partners.filter(pk=request.user.pk).exists()
Expand All @@ -171,7 +179,11 @@ def dispatch(self, request, *args, **kwargs):
)
# If the requesting user submitted the application, return the Applicant view.
# Reviewers may sometimes be applicants as well.
if submission.user == request.user:
# or if requesting user is a co-applicant to application, return the Applicant view.
if (
submission.user == request.user
or submission.co_applicants.filter(user=request.user).exists()
):
return ApplicantSubmissionDetailView.as_view()(request, *args, **kwargs)
# Only allow community reviewers in submission with a community review state.
if not submission.community_review:
Expand Down
Loading