Delete application comments with the application#4585
Merged
Conversation
wes-otf
added
Type: Bug
frjo
added
Status: Needs testing
frjo
approved these changes
Jun 16, 2025
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs testing
theskumar
added a commit
that referenced
this pull request
Jun 20, 2025
* origin/main: Fix report file path issue and duplicate file issue, Fix file path issue for Project and SOW Form (#4580) Use xhtml2pdf inplace of reportlab for submission pdf export (#4577) Fix co-applicant permission for Partners, Reviewers, and Community Reviewers (#4583) Migrate django-fsm to django-viewflow (#4561) Delete application comments with the application (#4585)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small code change to delete all associated comments from an application when the application itself is deleted. OTF has gotten lots of account deletion requests recently and this has prevented accounts from being deleted - applications are deleted but the comments prevent staff from deleting the account
There will probably be a bigger pass at these for data retention stuff later on but this is just a start