Better handling for users entering long names#4590
Merged
Conversation
… with fixes for names over 255 chars when applying
wes-otf
added
Type: Bug
Member
|
Can we do this pull request against the themes branch please? |
wes-otf
requested review from
frjo and
theskumar
and removed request for
theskumar
Contributor
Author
|
@theskumar wasn't thinking when I made the branch originally - should be set now though |
theskumar
requested changes
Jun 20, 2025
| class FullNameBlock(ApplicationMustIncludeFieldBlock): | ||
| name = "full_name" | ||
| description = "Full name" | ||
| widget = forms.TextInput() |
Member
There was a problem hiding this comment.
I think this is not needed. I need to remove from the title block as well.
Contributor
Author
There was a problem hiding this comment.
it wasn't! I also removed it from the title block too so you didn't have to
Member
|
Minor comment, otherwise looks good to me. I think you can ahead and merge after that minor change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4589. This adds a global max character limit to the
full_namefield, working both in the application form and the account settings. There's a few other fixes also bundled in this:Test Steps
FORCE_LOGIN_FOR_APPLICATION = False