Skip to content

Removed nested htmx call causing triggering of submission export.#4604

Merged
frjo merged 1 commit into
mainfrom
fix/export-submissions-triggered-on-query
Jul 11, 2025
Merged

Removed nested htmx call causing triggering of submission export.#4604
frjo merged 1 commit into
mainfrom
fix/export-submissions-triggered-on-query

Conversation

@frjo

@frjo frjo commented Jul 11, 2025

Copy link
Copy Markdown
Member

This got lost in the themes merge.

@frjo frjo added Type: Bug Bugs! Things that are broken :-/ Type: Minor Minor change, used in release drafter labels Jul 11, 2025
@frjo

frjo commented Jul 11, 2025

Copy link
Copy Markdown
Member Author

@wes-otf Does this look correct?

@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jul 11, 2025
@theskumar

Copy link
Copy Markdown
Member

Is it currently happening? In the themes, it's converted to link instead of button and I can't reproduce it.

@frjo

frjo commented Jul 11, 2025

Copy link
Copy Markdown
Member Author

On the test site I saw this issue earlier today, now this PR is on test so no more issue.

You only see it when celery/async is in place.

@theskumar

Copy link
Copy Markdown
Member

okay, make sense i didn't had that enabled locally

@wes-otf wes-otf added Status: Tested - approved for live ✅ and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Jul 11, 2025
@wes-otf

wes-otf commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

worked for me!

@frjo frjo merged commit b9260f9 into main Jul 11, 2025
7 checks passed
@theskumar theskumar deleted the fix/export-submissions-triggered-on-query branch July 20, 2025 09:13
wes-otf added a commit to OpenTechFund/apply-app that referenced this pull request Aug 13, 2025
…phaApp#4604)

This got lost in the themes merge.

Co-authored-by: Wes Appler <145372368+wes-otf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Tested - approved for live ✅ Type: Bug Bugs! Things that are broken :-/ Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants