Functionality for the deleting application attachments#4624
Merged
Conversation
wes-otf
force-pushed
the
fix/remove-orphaned-attachements
branch
from
eda7c6d to
53f8c41
Compare
Contributor
Author
|
There's a few more things left on this PR:
|
wes-otf
added
Type: Enhancement
…fix tests, it didn't
wes-otf
force-pushed
the
fix/remove-orphaned-attachements
branch
from
8340aeb to
3b515a2
Compare
wes-otf
commented
Oct 9, 2025
Comment on lines
+21
to
+25
| # TODO: This solution is not ideal but due to our unit tests writing to the filesystem | ||
| # this can cause files belonging to the dev's local server to be deleted. Until | ||
| # these can be better isolated, this signal will do nothing when pytest is running | ||
| if "pytest" in sys.modules: | ||
| return |
Contributor
Author
There was a problem hiding this comment.
This solution isn't ideal but I think until we can take a larger pass at our tests and making them more isolated it makes sense? When trying to run actual tests the files for applications on my local server were getting deleted, along with some weird stuff coming up in the unit tests that I couldn't recreate in a running instance.
Contributor
Author
|
All worked well on test! I've tested both on local storage and AWS, all deleted the attachments as they were supposed to. Gonna merge this |
wes-otf
added
Status: Tested - approved for live ✅
and removed
Status: Needs dev testing 🧑💻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4622. Deletes application attachments when an application is deleted and includes a migration to retroactively delete orphaned attachments.
Also removes a debug statement accidentally included in a PR
Test Steps