Fix missing org name (short and long) in email templates#4638
Merged
Conversation
Contributor
Author
|
I just realized this breaks Edit: I ended up fixing the duplicate messages manually by opening the |
Contributor
|
Hey this looks good, thanks for putting it up! I think I'm going to open another PR after merging this that'll automatically add the |
1 task
wes-otf
added a commit
that referenced
this pull request
Jan 9, 2026
…ntexts (#4647) …`MarkdownMail` renderer <!-- Thanks for contributing to Hypha! Please ensure your contributions pass all necessary linting/testing and that the appropriate documentation has been updated. --> <!-- Describe briefly what your pull request changes. If this is resolving an issue, please specify below via "Fixes #<Github Issue ID>" --> Relates to #4638 - removes the redundant markdown email contexts in favor of just utilizing the `global_vars` context processor ## Test Steps <!-- If step does not require manual testing, skip/remove this section. Give a brief overview of the steps required for a user/dev to test this contribution. Important things to include: - Required user roles for where necessary (ie. "As a Staff Admin...") - Clear & validatable expected results (ie. "Confirm the submit button is now not clickable") - Language that can be understood by non-technical testers if being tested by users --> - [ ] Ensure all markdown emails still look as they did before
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the signature of the application notification emails was off:
While investigating I found out that the
base.htmlemail template was usingorg_long_nameinstead ofORG_LONG_NAME(which is what theglobal_varscontext processor is providing).This issue appears to be widespread, and it's not helped by the fact that some emails correctly receive the
org_long_namevariable (it's passed manually in the context).For this PR, I went with the exhaustive approach of replacing every single instance of
org_long_name,org_short_name, andorg_emailwith their uppercase counterparts: