Skip to content

Fix styling of strapline on homepage#4639

Merged
wes-otf merged 3 commits into
HyphaApp:mainfrom
bmispelon:ticket-4634-strapline-styling
Dec 5, 2025
Merged

Fix styling of strapline on homepage#4639
wes-otf merged 3 commits into
HyphaApp:mainfrom
bmispelon:ticket-4634-strapline-styling

Conversation

@bmispelon

Copy link
Copy Markdown
Contributor

Fixes #4634

Screenshots

Before Screenshot 2025-11-26 at 16-20-33 Demo Apply Homepage ACME
After Screenshot 2025-11-26 at 16-19-20 Demo Apply Homepage ACME

Comment thread hypha/home/templates/home/home.html Outdated

{% if settings.core.SystemSettings.home_strapline %}
<p class="mb-8 text-fg-muted text-pretty">{{ settings.core.SystemSettings.home_strapline|nh3|safe }}</p>
<div class="strapline">{{ settings.core.SystemSettings.home_strapline|nh3|safe }}</div>

@frjo frjo Nov 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test with adding the "prose" class instead of the styles in strapline.css?

<div class="mb-8 text-fg-muted text-pretty prose">{{ settings.core.SystemSettings.home_strapline|nh3|safe }}</div>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't quite look the same (in particular the styling of the link could be improved I think), but it is much simpler code-wise indeed. I've pushed a new commit.

Screenshot Screenshot 2025-11-27 at 08-49-33 Demo Apply Homepage ACME

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I could use the prose-a:text-primary class to add styling to the links inside the strapline. Would you be open that that change too?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an extra commit ✅

@frjo frjo self-requested a review November 27, 2025 08:48
@wes-otf wes-otf added Type: Patch Mini change, used in release drafter Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team Status: Tested - approved for live ✅ and removed Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Dec 3, 2025
@wes-otf wes-otf merged commit 2e95dbf into HyphaApp:main Dec 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Tested - approved for live ✅ Type: Patch Mini change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[regression] Strapline on homepage is unstyled

3 participants