Skip to content

Fix crash when creating a Fund without projects enabled #4642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wes-otf merged 1 commit into from
Dec 5, 2025
+4 −2
Merged

Fix crash when creating a Fund without projects enabled #4642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions hypha/apply/funds/admin_forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ def clean(self):
review_forms = self.formsets["review_forms"]
external_review_forms = self.formsets["external_review_forms"]
determination_forms = self.formsets["determination_forms"]
paf_forms = self.formsets["approval_forms"]
number_of_stages = len(workflow.stages)

self.validate_application_forms(workflow, application_forms)
Expand All @@ -33,7 +32,10 @@ def clean(self):
self.validate_stages_equal_forms(
workflow, determination_forms, form_type="Determination form"
)
self.validate_paf_form(paf_forms)

if settings.PROJECTS_ENABLED:
paf_forms = self.formsets["approval_forms"]
self.validate_paf_form(paf_forms)

@frjo frjo Nov 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean and easy to understand.


return cleaned_data

Expand Down
Loading