Release 1.7.2 (#452)

Author: Aerex

bluemix/terminal/ui.go

@@ -64,9 +64,18 @@ type UI interface {
 	// Table creates a table with the given headers
 	Table(headers []string) Table
 
-	// Writer returns writer of the terminal UI
+	// Writer returns the output writer of the terminal UI
 	Writer() io.Writer
 
+	// SetWriter sets the writer of the terminal UI
+	SetWriter(buf io.Writer)
+
+	// ErrWriter returns the error writer of the terminal UI
+	ErrWriter() io.Writer
+
+	// SetErrWriter sets the error writer of the terminal UI
+	SetErrWriter(buf io.Writer)
+
 	// Enable or disable quiet mode. Contents passed to Verbose(), Warn(), OK() will be ignored if under quiet mode.
 	SetQuiet(bool)
 
@@ -217,6 +226,18 @@ func (ui *terminalUI) Writer() io.Writer {
 	return ui.Out
 }
 
+func (ui *terminalUI) ErrWriter() io.Writer {
+	return ui.ErrOut
+}
+
+func (ui *terminalUI) SetWriter(buf io.Writer) {
+	ui.Out = buf
+}
+
+func (ui *terminalUI) SetErrWriter(buf io.Writer) {
+	ui.ErrOut = buf
+}
+
 func (ui *terminalUI) SetQuiet(quiet bool) {
 	ui.quiet = quiet
 }

go.mod

@@ -1,6 +1,8 @@
 module github.com/IBM-Cloud/ibm-cloud-cli-sdk
 
-go 1.22.12
+go 1.23.0
+
+toolchain go1.23.6
 
 require (
 	github.com/fatih/color v1.7.1-0.20180516100307-2d684516a886

plugin/plugin.go

@@ -111,6 +111,12 @@ func (c Command) NameAndAliases() []string {
 // Method is used when defining the Flags in command metadata. @see Plugin#GetMetadata() for use case
 func ConvertCobraFlagsToPluginFlags(cmd *cobra.Command) []Flag {
 	var flags []Flag
+	// NOTE: there is a strange behavior in Cobra where you need to call
+	// either `InheritedFlags` or `LocalFlags` in order to include global
+	// flags when calling `VisitAll`
+	// see https://github.com/spf13/cobra/issues/412
+	cmd.InheritedFlags()
+
 	cmd.Flags().VisitAll(func(f *pflag.Flag) {
 		var name string
 		if f.Shorthand != "" {

testhelpers/terminal/test_ui.go

@@ -27,6 +27,9 @@ type FakeUI struct {
 	PasswordPrompts []string
 	ChoicesPrompts  []choicesPrompt
 	WarnOutputs     []string
+	stdoutWriter    io.Writer
+	stdErrWriter    io.Writer
+	stdInWriter     io.Reader
 
 	inputs bytes.Buffer
 	stdOut bytes.Buffer
@@ -221,6 +224,22 @@ func (ui *FakeUI) Writer() io.Writer {
 	return &ui.stdOut
 }
 
+func (ui *FakeUI) ErrWriter() io.Writer {
+	return &ui.stdErr
+}
+
+// NOTE: SetErrWriter is added here since the method is part of the UI type Interface interface
+// the method is not needed for testing
+func (ui *FakeUI) SetErrWriter(buf io.Writer) {
+	panic("unimplemented")
+}
+
+// NOTE: SetErrWriter is added here since the method is part of the UI type Interface interface
+// the method is not needed for testing
+func (ui *FakeUI) SetWriter(buf io.Writer) {
+	panic("unimplemented")
+}
+
 func (ui *FakeUI) SetQuiet(quiet bool) {
 	ui.quiet = quiet
 }