Conversation
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.26.4' |
There was a problem hiding this comment.
Callout: I am using the exact version in the go.mod to ensure that the build matches what is currently being used.
When we update the go version in the sdk we will need to update this value accordingly
There was a problem hiding this comment.
It would be nice if we could pick this up in an automated fashion. It's not the end of the world, we used to have to do this manual update with travis too, but worth considering.
There was a problem hiding this comment.
It looks like there is an option for that for setup-go GitHub Action. I have made the change
| dumpedRequest, err := httputil.DumpRequest(req, shouldDisplayBody) | ||
| if err != nil { | ||
| trace.Logger.Printf(T("An error occurred while dumping request:\n{{.Error}}\n", map[string]interface{}{"Error": err.Error()})) | ||
| trace.Logger.Print(T("An error occurred while dumping request:\n{{.Error}}\n", map[string]interface{}{"Error": err.Error()})) |
There was a problem hiding this comment.
Just wondering why this was necessary?
There was a problem hiding this comment.
This is to avoid the vet errors when running the unit tests
2 participants
Context
This PR will add GitHub actions that will build and run the unit tests on every push and pull request