Skip to content

build: added GitHub Actions for push and pull_request events #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aerex merged 3 commits into from
Jun 16, 2026
Merged

build: added GitHub Actions for push and pull_request events #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
511383f
chore: fixed non-constant format string in Printf call
Aerex Jun 12, 2026
65495e0
build: added GitHub actions for push and pull request events
Aerex Jun 12, 2026
7939d1c
build: retrieve go version from go mod
Aerex Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: ci

on: [push, pull_request]

jobs:
build:

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version-file: 'go.mod'
- name: Display Go version
run: go version
- name: Build Dependencies
run: go mod tidy && go mod vendor
- name: Run Tests
run: go test -v -count=1 ./...
4 changes: 2 additions & 2 deletions bluemix/http/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (r *TraceLoggingTransport) dumpRequest(req *http.Request, start time.Time)

dumpedRequest, err := httputil.DumpRequest(req, shouldDisplayBody)
if err != nil {
trace.Logger.Printf(T("An error occurred while dumping request:\n{{.Error}}\n", map[string]interface{}{"Error": err.Error()}))
trace.Logger.Print(T("An error occurred while dumping request:\n{{.Error}}\n", map[string]interface{}{"Error": err.Error()}))

@steveclay steveclay Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why this was necessary?

@Aerex Aerex Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to avoid the vet errors when running the unit tests

return
}

Expand All @@ -76,7 +76,7 @@ func (r *TraceLoggingTransport) dumpResponse(res *http.Response, start time.Time

dumpedResponse, err := httputil.DumpResponse(res, shouldDisplayBody)
if err != nil {
trace.Logger.Printf(T("An error occurred while dumping response:\n{{.Error}}\n", map[string]interface{}{"Error": err.Error()}))
trace.Logger.Print(T("An error occurred while dumping response:\n{{.Error}}\n", map[string]interface{}{"Error": err.Error()}))
return
}

Expand Down
2 changes: 1 addition & 1 deletion bluemix/trace/trace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func NewFileLogger(path string) PrinterCloser {
file, err := os.OpenFile(filepath.Clean(path), os.O_CREATE|os.O_RDWR|os.O_APPEND, 0600)
if err != nil {
logger := NewStdLogger()
logger.Printf(T("An error occurred when creating log file '{{.Path}}':\n{{.Error}}\n\n", map[string]interface{}{"Path": path, "Error": err.Error()}))
logger.Print(T("An error occurred when creating log file '{{.Path}}':\n{{.Error}}\n\n", map[string]interface{}{"Path": path, "Error": err.Error()}))
return logger
}
return newLoggerImpl(file, "", 0)
Expand Down
Loading