Skip to content

Commit 182124a

Browse files
committed
fix: drop cargo deny from rust ci
Signed-off-by: lucarlig <luca.carlig@ibm.com>
1 parent e97a1c0 commit 182124a

3 files changed

Lines changed: 5 additions & 13 deletions

File tree

.github/workflows/ci-rust-python-package.yaml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ on:
66
paths:
77
- "Makefile"
88
- "Cargo.toml"
9-
- "deny.toml"
109
- "crates/**"
1110
- "README.md"
1211
- "DEVELOPING.md"
@@ -21,7 +20,6 @@ on:
2120
paths:
2221
- "Makefile"
2322
- "Cargo.toml"
24-
- "deny.toml"
2523
- "crates/**"
2624
- "README.md"
2725
- "DEVELOPING.md"
@@ -130,15 +128,12 @@ jobs:
130128
rustc --version
131129
cargo --version
132130
133-
- name: Install cargo audit tools
134-
run: cargo install cargo-audit@0.22.1 cargo-deny@0.19.0 --locked
131+
- name: Install cargo audit
132+
run: cargo install cargo-audit@0.22.1 --locked
135133

136134
- name: Run cargo audit
137135
run: cargo audit --file Cargo.lock
138136

139-
- name: Run cargo deny license policy checks
140-
run: cargo deny check licenses --config deny.toml
141-
142137
coverage:
143138
needs: validate-and-detect
144139
if: needs.validate-and-detect.outputs.has_plugins == 'true'

tests/test_plugin_catalog.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1629,7 +1629,6 @@ def test_ci_workflow_shared_paths_match_catalog_contract(self) -> None:
16291629
expected_paths = {
16301630
"Makefile",
16311631
"Cargo.toml",
1632-
"deny.toml",
16331632
"crates/**",
16341633
"README.md",
16351634
"DEVELOPING.md",
@@ -1879,13 +1878,12 @@ def test_ci_workflow_includes_parity_jobs_for_rust_plugin_checks(self) -> None:
18791878
self.assertIn("if: needs.validate-and-detect.outputs.has_plugins == 'true'", security_section)
18801879
self.assertIn("if: needs.validate-and-detect.outputs.has_plugins == 'true'", coverage_section)
18811880
self.assertIn("if: needs.validate-and-detect.outputs.has_plugins == 'true'", documentation_section)
1882-
self.assertIn("cargo install cargo-audit@0.22.1 cargo-deny@0.19.0 --locked", security_section)
1881+
self.assertIn("cargo install cargo-audit@0.22.1 --locked", security_section)
18831882
self.assertIn("cargo audit --file Cargo.lock", security_section)
1884-
self.assertIn("cargo deny check licenses --config deny.toml", security_section)
1883+
self.assertNotIn("cargo-deny", security_section)
1884+
self.assertNotIn("cargo deny", security_section)
18851885
self.assertNotIn("--workspace", security_section)
18861886
self.assertNotIn("--manifest-path", security_section)
1887-
self.assertIn("--config deny.toml", security_section)
1888-
self.assertNotIn("/deny.toml", security_section.replace("--config deny.toml", ""))
18891887
self.assertNotIn("matrix:", security_section)
18901888
self.assertIn("cargo install cargo-llvm-cov --version 0.8.4 --locked", coverage_section)
18911889
self.assertIn("package='${{ needs.validate-and-detect.outputs.single_cargo_package }}'", coverage_section)

tools/plugin_catalog.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
"Makefile",
2121
".github/workflows/",
2222
"Cargo.toml",
23-
"deny.toml",
2423
"crates/",
2524
"README.md",
2625
"DEVELOPING.md",

0 commit comments

Comments
 (0)