Draft
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cargo.lockfrom forcing all plugins when plugin-specific paths identify the changed plugin setCargo.lockplus one plugin pathFixes #80
Validation
python3 -m unittest tests.test_plugin_catalog.PluginCatalogTests.test_ci_selection_treats_cargo_lock_change_as_all_plugins tests.test_plugin_catalog.PluginCatalogTests.test_ci_selection_keeps_cargo_lock_with_plugin_change_plugin_scopedpython3 tools/plugin_catalog.py validate .python3 tools/plugin_catalog.py ci-selection . diff a028daee84c0879bda1a38b59111afecbf044b87 c628d106327bf595c024d7fe515abcab7d7ff903