Restrict PVC and secret creation in same namespace during provisioning#306
Open
Prachi030510 wants to merge 12 commits intomainfrom
Open
Restrict PVC and secret creation in same namespace during provisioning#306Prachi030510 wants to merge 12 commits intomainfrom
Prachi030510 wants to merge 12 commits intomainfrom
Conversation
Collaborator
|
👍 Coverage remained same at 84.86% |
mssachan
reviewed
Apr 9, 2026
mssachan
requested changes
Apr 9, 2026
Member
mssachan
left a comment
mssachan
left a comment
There was a problem hiding this comment.
Changes looks good. Added minor comment. PTAL
Collaborator
|
👍 Coverage remained same at 84.86% |
mssachan
requested changes
Apr 13, 2026
| secret, err := cs.Stats.GetSecret(customSecretName, secretNamespace) | ||
| if err != nil { | ||
| return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("Secret resource not found %v", err)) | ||
| return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("error getting Secret: %v", err)) |
Member
There was a problem hiding this comment.
With this change, log message will look like as given below:
error getting Secret: error getting Secret: secrets "test-cos-secret1" not found
Please verify and make the changes accordingly.
Collaborator
|
👍 Coverage remained same at 84.86% |
Collaborator
|
👍 Coverage remained same at 84.86% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review