Skip to content

Commit 3c1ca03

Browse files
lucarligclaudia-gray
authored andcommitted
fix: remove setup-node from GitHub workflows (#4079)
* fix: remove setup-node from GitHub workflows Signed-off-by: lucarlig <luca.carlig@ibm.com> * fix: install node manually in workflows Signed-off-by: lucarlig <luca.carlig@ibm.com> * fix: run npm upgrades with sudo in CI Signed-off-by: lucarlig <luca.carlig@ibm.com> --------- Signed-off-by: lucarlig <luca.carlig@ibm.com>
1 parent 1744faa commit 3c1ca03

3 files changed

Lines changed: 41 additions & 15 deletions

File tree

.github/workflows/lint-web.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,16 +112,25 @@ jobs:
112112
# -----------------------------------------------------------
113113
# 1️⃣ Node.js Setup
114114
# -----------------------------------------------------------
115-
- name: 📦 Set up Node.js
116-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
117-
with:
118-
node-version: '20'
115+
- name: 📦 Install Node.js 20
116+
run: |
117+
sudo apt-get update
118+
sudo apt-get install -y ca-certificates curl gnupg
119+
sudo mkdir -p /etc/apt/keyrings
120+
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
121+
| sudo gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
122+
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" \
123+
| sudo tee /etc/apt/sources.list.d/nodesource.list > /dev/null
124+
sudo apt-get update
125+
sudo apt-get install -y nodejs
126+
node --version
127+
npm --version
119128
120129
# -----------------------------------------------------------
121130
# 🔧 Configure npm
122131
# -----------------------------------------------------------
123132
- name: 🔧 Upgrade npm to minimum required version
124-
run: npm install -g npm@^11.10.0
133+
run: sudo npm install -g npm@^11.10.0
125134

126135
- name: 🔧 Configure npm registry
127136
run: npm config set registry https://registry.npmjs.org/

.github/workflows/linting-full.yml

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,19 @@ jobs:
4646
mcp-servers/go/fast-time-server/go.sum
4747
mcp-servers/go/slow-time-server/go.sum
4848
49-
- name: Set up Node.js
50-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
51-
with:
52-
node-version: "22"
49+
- name: Install Node.js 22
50+
run: |
51+
sudo apt-get update
52+
sudo apt-get install -y ca-certificates curl gnupg
53+
sudo mkdir -p /etc/apt/keyrings
54+
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
55+
| sudo gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
56+
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_22.x nodistro main" \
57+
| sudo tee /etc/apt/sources.list.d/nodesource.list > /dev/null
58+
sudo apt-get update
59+
sudo apt-get install -y nodejs
60+
node --version
61+
npm --version
5362
5463
- name: Set up Helm
5564
uses: azure/setup-helm@bf6a7d304bc2fdb57e0331155b7ebf2c504acf0a # v4

.github/workflows/vitest.yml

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -55,17 +55,25 @@ jobs:
5555
# -----------------------------------------------------------
5656
# 1️⃣ Node.js Setup
5757
# -----------------------------------------------------------
58-
- name: 📦 Set up Node.js
59-
uses: actions/setup-node@a0853c24544627f65ddf259abe73b1d18a591444 # v5
60-
with:
61-
node-version: '20'
62-
cache: npm
58+
- name: 📦 Install Node.js 20
59+
run: |
60+
sudo apt-get update
61+
sudo apt-get install -y ca-certificates curl gnupg
62+
sudo mkdir -p /etc/apt/keyrings
63+
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key \
64+
| sudo gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
65+
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" \
66+
| sudo tee /etc/apt/sources.list.d/nodesource.list > /dev/null
67+
sudo apt-get update
68+
sudo apt-get install -y nodejs
69+
node --version
70+
npm --version
6371
6472
# -----------------------------------------------------------
6573
# 2️⃣ Upgrade npm to minimum required version
6674
# -----------------------------------------------------------
6775
- name: 🔧 Upgrade npm to minimum required version
68-
run: npm install -g npm@^11.10.0
76+
run: sudo npm install -g npm@^11.10.0
6977

7078
# -----------------------------------------------------------
7179
# 3️⃣ Install Dependencies

0 commit comments

Comments
 (0)