Skip to content

Commit ddecc7c

Browse files
crivetimihaiomorrosjonpspri
authored
test(api): add regression coverage for prompt original_name during federation (#3087) (#3208)
* test(gateway): add regression tests for prompt original_name during federation Add assertions to verify that original_name, custom_name, and display_name are correctly set during federation prompt creation (issue #3087). Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk> * .secrets.baseline Signed-off-by: Jonathan Springer <jps@s390x.com> --------- Signed-off-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk> Signed-off-by: Jonathan Springer <jps@s390x.com> Co-authored-by: Oriol Morros Vilaseca <OM368@student.aru.ac.uk> Co-authored-by: Jonathan Springer <jps@s390x.com>
1 parent 593c4ab commit ddecc7c

2 files changed

Lines changed: 20 additions & 8 deletions

File tree

.secrets.baseline

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"files": "^.secrets.baseline|package-lock.json|Cargo.lock|scripts/sign_image.sh|scripts/zap|sonar-project.properties|uv.lock|^.secrets.baseline$",
44
"lines": null
55
},
6-
"generated_at": "2026-04-11T13:00:03Z",
6+
"generated_at": "2026-04-11T14:12:29Z",
77
"plugins_used": [
88
{
99
"name": "AWSKeyDetector"
@@ -9044,55 +9044,55 @@
90449044
"hashed_secret": "99834bc4eff3f1e1c1e4692d2476b593b501d045",
90459045
"is_secret": false,
90469046
"is_verified": false,
9047-
"line_number": 5033,
9047+
"line_number": 5045,
90489048
"type": "Secret Keyword",
90499049
"verified_result": null
90509050
},
90519051
{
90529052
"hashed_secret": "f2b14f68eb995facb3a1c35287b778d5bd785511",
90539053
"is_secret": false,
90549054
"is_verified": false,
9055-
"line_number": 5038,
9055+
"line_number": 5050,
90569056
"type": "Secret Keyword",
90579057
"verified_result": null
90589058
},
90599059
{
90609060
"hashed_secret": "1a91d62f7ca67399625a4368a6ab5d4a3baa6073",
90619061
"is_secret": false,
90629062
"is_verified": false,
9063-
"line_number": 6575,
9063+
"line_number": 6587,
90649064
"type": "Secret Keyword",
90659065
"verified_result": null
90669066
},
90679067
{
90689068
"hashed_secret": "2a23dd4f2e8b50315e601a2867ea7b7bf5a43b8c",
90699069
"is_secret": false,
90709070
"is_verified": false,
9071-
"line_number": 7172,
9071+
"line_number": 7184,
90729072
"type": "Secret Keyword",
90739073
"verified_result": null
90749074
},
90759075
{
90769076
"hashed_secret": "ed3e0017cb8e4b06a59af1a441f62cbe58d2ef59",
90779077
"is_secret": false,
90789078
"is_verified": false,
9079-
"line_number": 7191,
9079+
"line_number": 7203,
90809080
"type": "Secret Keyword",
90819081
"verified_result": null
90829082
},
90839083
{
90849084
"hashed_secret": "b55c6dc4705dba8b151c59566175ad845d5a9104",
90859085
"is_secret": false,
90869086
"is_verified": false,
9087-
"line_number": 7397,
9087+
"line_number": 7409,
90889088
"type": "Secret Keyword",
90899089
"verified_result": null
90909090
},
90919091
{
90929092
"hashed_secret": "3654bd5ef523a79741766b7c3f22228fd43c3836",
90939093
"is_secret": false,
90949094
"is_verified": false,
9095-
"line_number": 7416,
9095+
"line_number": 7428,
90969096
"type": "Secret Keyword",
90979097
"verified_result": null
90989098
}

tests/unit/mcpgateway/services/test_gateway_service.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3978,6 +3978,12 @@ async def test_register_gateway_creates_new_resources_and_prompts(gateway_servic
39783978
assert added_gateway.prompts[0].title == "Prompt Title"
39793979

39803980

3981+
# Regression: verify namespacing fields are set (issue #3087)
3982+
federated_prompt = added_gateway.prompts[0]
3983+
assert federated_prompt.original_name == "Prompt"
3984+
assert federated_prompt.custom_name == "Prompt"
3985+
assert federated_prompt.display_name == "Prompt"
3986+
39813987

39823988
@pytest.mark.asyncio
39833989
async def test_shutdown_releases_redis_leader_success():
@@ -4754,6 +4760,12 @@ def test_new_prompt_created(self, gateway_service):
47544760
result = gateway_service._update_or_create_prompts(db, [prompt], gw, "test")
47554761
assert len(result) == 1
47564762

4763+
# Regression: verify namespacing fields are set (issue #3087)
4764+
created = result[0]
4765+
assert created.original_name == "new-prompt"
4766+
assert created.custom_name == "new-prompt"
4767+
assert created.display_name == "new-prompt"
4768+
47574769
def test_existing_prompt_updated(self, gateway_service, mock_gateway):
47584770
existing = MagicMock()
47594771
existing.original_name = "my-prompt"

0 commit comments

Comments
 (0)