chore: add missing rust crates to workspace#5305
Merged
Merged
Conversation
lucarlig
force-pushed
the
user/luca/rust-workspace-members
branch
2 times, most recently
from
a2b97df to
b533dab
Compare
lucarlig
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai,
ja8zyjits and
msureshkumar88
as code owners
lucarlig
force-pushed
the
user/luca/rust-workspace-members
branch
2 times, most recently
from
4837b87 to
8b6beb9
Compare
lucarlig
force-pushed
the
user/luca/rust-workspace-members
branch
from
8b6beb9 to
2cb905b
Compare
cafalchio
reviewed
Jun 23, 2026
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
force-pushed
the
user/luca/rust-workspace-members
branch
from
2cb905b to
b22f898
Compare
ja8zyjits
previously approved these changes
Jun 23, 2026
ja8zyjits
left a comment
ja8zyjits
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Process followed
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: lucarlig <luca.carlig@ibm.com>
jonpspri
added a commit
that referenced
this pull request
Jun 26, 2026
The crate's Cargo.toml uses workspace inheritance (.workspace = true) for every package field and dependency. The previous Containerfile copied only the crate-local Cargo.toml into the build context, which caused cargo to fail with 'failed to find a workspace root' (exit 101) the moment PR #5305 added this crate to the root workspace. Rewrite the Containerfile to copy the root Cargo.toml/Cargo.lock and the workspace members (crates/, a2a-agents/, mcp-servers/rust/), then build with 'cargo build --release -p fast-time-server'. The build now runs from the repo root; see the compose and Makefile changes in sibling commits for the matching wiring. Also remove the orphan Dockerfile: it had the identical bug, no consumers in the repo (no Makefile, compose, CI, or Helm reference it), and an inconsistent port (8880 vs the 9080 the README documents). Add Containerfile to the .dockerignore allow-list for parity with the slow-time-server pattern. Signed-off-by: Jonathan Springer <jps@s390x.com> (cherry picked from commit 6034102)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
Closes #5304
Summary
Adds the missing Rust MCP server crates to the top-level Cargo workspace so root-level Cargo commands cover their dependency resolution. The MCP server crates keep explicit package versions, while compatible metadata, lints, and shared dependency versions inherit from the root workspace. The release guide now uses a single
cargo update --workspacefor Rust dependency updates.Reviewability
triageType of Change
Verification
cargo update --workspacecargo check --workspace --all-targetscargo clippy --workspace --all-targets -- -D warningsmake rust-vetcargo fmt --check --allcargo buildfrommcp-servers/rust/fast-time-server, thentarget/debug/fast-time-servergit diff --checkgit commit --amend -s --no-edit8b6beb90d1e4cdc8e318f33fc867e808c60778b2Checklist
cargo fmt --check --all)Notes (optional)
Fixes the CI failures by replacing an MSRV-incompatible
OsStr::display()call, removing unused filesystem-server dependencies from the root lock graph, adding cargo-vet exemptions for the remaining newly covered runtime/macro dependencies, and updating the SQL sanitizer workflow to launch the fast-time-server binary from the workspace target directory.