Skip to content

Replace request with isomorphic-unfetch#315

Open
JsonKim wants to merge 1 commit intoIBM:masterfrom
JsonKim:isomorphic-unfetch
Open

Replace request with isomorphic-unfetch#315
JsonKim wants to merge 1 commit intoIBM:masterfrom
JsonKim:isomorphic-unfetch

Conversation

@JsonKim
Copy link
Copy Markdown

@JsonKim JsonKim commented Apr 26, 2020

request has been deprecated since Feb 2020. And I want to use openapi-to-graphql on client-side. However, I can't because request uses fs. So I make and open this pr.

@JsonKim JsonKim force-pushed the isomorphic-unfetch branch from 2e98a77 to 01d4e05 Compare April 26, 2020 09:37
@Alan-Cha
Copy link
Copy Markdown
Collaborator

@JsonKim This is a very important change! Thank you very much!

I'm not familiar with request alternatives. Could you give us some insight into why this particular library was selected?

@ErikWittern
Copy link
Copy Markdown
Collaborator

@JsonKim @Alan-Cha I guess one starting point is to look at the list of alternative libraries that the request team itself compiled: request/request#3143

@JsonKim
Copy link
Copy Markdown
Author

JsonKim commented Apr 29, 2020

@ErikWittern Thanks! @Alan-Cha https://github.com/developit/unfetch is lighter and simpler than other alternatives. And it can be used in both server-side and client-side because it supports polyfill. If you suggest another alternative, I can work on that as well.

Signed-off-by: Jason Kim <actcrazy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants