Don't set the content-type when there is no payload#325
Don't set the content-type when there is no payload#325lionelschiepers wants to merge 2 commits intoIBM:masterfrom
Conversation
The HTTP Get operation actually set a content-type of 'application/json' when there is no payload. The request adds a content-length of 0 because there is no payload. Web server like https://github.com/stoplightio/prism (mock of openapi) reject the calls because the content-type has nothing to do with GET operations. Exemple: GET http://127.0.0.1:4010/RESTMethod HTTP/1.1 content-type: application/json accept: application/json host: 127.0.0.1:4010 content-length: 0 Connection: close Signed-off-by: Lionel Schiepers <lionel.schiepers@belgiantrain.be>
fix: check if there is a payload by checking the http method instead of payloadRequired because that field is not always correctly initialized during unit test Signed-off-by: Lionel Schiepers <lionel.schiepers@belgiantrain.be>
|
Hi, I'm not a specialist of node.js/javascript. I tried to find the reason why payloadRequired was not correctly initialized during the unit test but didn't find the reason. That's why I changed the logic by checking the method instead of payloadRequired. Do you have any advise? Lionel. |
|
@lionelschiepers I apologize for the late reply! A lot of things have been going on at my end. We set the Let me give it a shot... |
|
Ah sorry, I got a bit ahead of myself. It seems that you have already made the changes. This is the way I would have done as well. I do not think we should make things more complicated by checking if the payload is required. Do these changes address your issue? Do you have any other problems with OtG? |
|
Hi, Yes. This pullrequest solves my problem. If every body agree on the change I would be the most happiest man in the world if the pullrequest is merged :-) Thanks, |
|
@lionelschiepers I can try to get this checked in later today. I think we need a test case which I will look into. |
2 participants
Hi,
I can't use the Mock Web Server https://github.com/stoplightio/prism because the GET operations set a content-type & content-length in the http headers. I think it's an error. a content-type & content-length must be set when there is a payload with operations like 'PUT' or 'POST'...
Web server like https://github.com/stoplightio/prism (mock of openapi) rejects the calls because it validate the request and a content-type has nothing to do with GET operations.
Exemple of a call made by openapi-to-graphql to my openapi web server:
GET http://127.0.0.1:4010/RESTMethod HTTP/1.1
content-type: application/json (bad)
accept: application/json
host: 127.0.0.1:4010
content-length: 0 (bad)
Connection: close