This repository was archived by the owner on Jun 2, 2026. It is now read-only.
Handle recursive union types#457
Open
smeyffret wants to merge 1 commit into
Open
Conversation
checkAmbiguousMemberTypes might trigger calls to createOrReuseUnion when fetching the fields of a given type. However, if graphQLType is not defined yet, it will try to create it instead of returning the previously created one. In order to reuse graphQLType without creating a new one, we need to call checkAmbiguousMemberTypes **after** assigning the graphQLType to the current definition. Signed-off-by: Simon Meyffret <smeyffret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkAmbiguousMemberTypes might trigger calls to createOrReuseUnion when
fetching the fields of a given type. However, if graphQLType is not
defined yet, it will try to create it instead of returning the
previously created one. In order to reuse graphQLType without creating a
new one, we need to call checkAmbiguousMemberTypes after assigning
the graphQLType to the current definition.
Motivation: #451
Signed-off-by: Simon Meyffret smeyffret@gmail.com